From: "Ilpo Järvinen" <ilpo.jarvinen@linux•intel.com>
To: Sreehari Kancharla <sreehari.kancharla@linux•intel.com>
Cc: Netdev <netdev@vger•kernel.org>,
kuba@kernel•org, davem@davemloft•net, johannes@sipsolutions•net,
ryazanov.s.a@gmail•com, loic.poulain@linaro•org,
m.chetan.kumar@intel•com, chandrashekar.devegowda@intel•com,
linuxwwan@intel•com, chiranjeevi.rapolu@linux•intel.com,
haijun.liu@mediatek•com, ricardo.martinez@linux•intel.com,
Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
dinesh.sharma@intel•com, moises.veleta@intel•com,
sreehari.kancharla@intel•com
Subject: Re: [PATCH net-next 2/2] net: wwan: t7xx: Add NAPI support
Date: Tue, 13 Sep 2022 13:45:58 +0300 (EEST) [thread overview]
Message-ID: <5820620-6450-e3f5-4ac0-e235cbf5c838@linux.intel.com> (raw)
In-Reply-To: <20220909163500.5389-2-sreehari.kancharla@linux.intel.com>
On Fri, 9 Sep 2022, Sreehari Kancharla wrote:
> From: Haijun Liu <haijun.liu@mediatek•com>
>
> Replace the work queue based RX flow with a NAPI implementation
> Remove rx_thread and dpmaif_rxq_work.
> Introduce dummy network device. its responsibility is
> - Binds one NAPI object for each DL HW queue and acts as
> the agent of all those network devices.
> - Use NAPI object to poll DL packets.
> - Helps to dispatch each packet to the network interface.
It would be useful to mention that GRO is also enabled.
> static int t7xx_ccmni_open(struct net_device *dev)
> {
> struct t7xx_ccmni *ccmni = wwan_netdev_drvpriv(dev);
> + struct t7xx_ccmni_ctrl *ccmni_ctl = ccmni->ctlb;
>
> netif_carrier_on(dev);
> netif_tx_start_all_queues(dev);
> + if (!atomic_read(&ccmni_ctl->napi_usr_refcnt)) {
> + t7xx_ccmni_enable_napi(ccmni_ctl);
> + atomic_set(&ccmni_ctl->napi_usr_refcnt, 1);
> + } else {
> + atomic_inc(&ccmni_ctl->napi_usr_refcnt);
> + }
atomic_fetch_inc() ?
--
i.
next prev parent reply other threads:[~2022-09-13 10:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 16:34 [PATCH net-next 1/2] net: wwan: t7xx: Use needed_headroom instead of hard_header_len Sreehari Kancharla
2022-09-09 16:35 ` [PATCH net-next 2/2] net: wwan: t7xx: Add NAPI support Sreehari Kancharla
2022-09-12 12:53 ` Loic Poulain
2022-10-10 14:22 ` Kancharla, Sreehari
2022-10-10 15:21 ` Andy Shevchenko
2022-10-20 14:22 ` Kancharla, Sreehari
2022-09-13 10:45 ` Ilpo Järvinen [this message]
2022-09-13 16:53 ` [PATCH net-next 1/2] net: wwan: t7xx: Use needed_headroom instead of hard_header_len Sergey Ryazanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5820620-6450-e3f5-4ac0-e235cbf5c838@linux.intel.com \
--to=ilpo.jarvinen@linux$(echo .)intel.com \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=chandrashekar.devegowda@intel$(echo .)com \
--cc=chiranjeevi.rapolu@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=dinesh.sharma@intel$(echo .)com \
--cc=haijun.liu@mediatek$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=linuxwwan@intel$(echo .)com \
--cc=loic.poulain@linaro$(echo .)org \
--cc=m.chetan.kumar@intel$(echo .)com \
--cc=moises.veleta@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ricardo.martinez@linux$(echo .)intel.com \
--cc=ryazanov.s.a@gmail$(echo .)com \
--cc=sreehari.kancharla@intel$(echo .)com \
--cc=sreehari.kancharla@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox