public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel•com>
To: Tianyu Lan <ltykernel@gmail•com>,
	kys@microsoft•com, haiyangz@microsoft•com,
	sthemmin@microsoft•com, wei.liu@kernel•org, decui@microsoft•com,
	tglx@linutronix•de, mingo@redhat•com, bp@alien8•de,
	x86@kernel•org, hpa@zytor•com, dave.hansen@linux•intel.com,
	luto@kernel•org, peterz@infradead•org, konrad.wilk@oracle•com,
	boris.ostrovsky@oracle•com, jgross@suse•com,
	sstabellini@kernel•org, joro@8bytes•org, will@kernel•org,
	davem@davemloft•net, kuba@kernel•org, jejb@linux•ibm.com,
	martin.petersen@oracle•com, arnd@arndb•de, hch@lst•de,
	m.szyprowski@samsung•com, robin.murphy@arm•com,
	Tianyu.Lan@microsoft•com, rppt@kernel•org,
	kirill.shutemov@linux•intel.com, akpm@linux-foundation•org,
	brijesh.singh@amd•com, thomas.lendacky@amd•com,
	pgonda@google•com, david@redhat•com, krish.sadhukhan@oracle•com,
	saravanand@fb•com, aneesh.kumar@linux•ibm.com,
	xen-devel@lists•xenproject.org, martin.b.radev@gmail•com,
	ardb@kernel•org, rientjes@google•com, tj@kernel•org,
	keescook@chromium•org, michael.h.kelley@microsoft•com
Cc: iommu@lists•linux-foundation.org, linux-arch@vger•kernel.org,
	linux-hyperv@vger•kernel.org, linux-kernel@vger•kernel.org,
	linux-scsi@vger•kernel.org, netdev@vger•kernel.org,
	vkuznets@redhat•com, parri.andrea@gmail•com
Subject: Re: [PATCH V2 03/14] x86/set_memory: Add x86_set_memory_enc static call support
Date: Wed, 4 Aug 2021 12:27:15 -0700	[thread overview]
Message-ID: <5823af8a-7dbb-dbb0-5ea2-d9846aa2a36a@intel.com> (raw)
In-Reply-To: <20210804184513.512888-4-ltykernel@gmail.com>

On 8/4/21 11:44 AM, Tianyu Lan wrote:
> +static int default_set_memory_enc(unsigned long addr, int numpages, bool enc);
> +DEFINE_STATIC_CALL(x86_set_memory_enc, default_set_memory_enc);
> +
>  #define CPA_FLUSHTLB 1
>  #define CPA_ARRAY 2
>  #define CPA_PAGES_ARRAY 4
> @@ -1981,6 +1985,11 @@ int set_memory_global(unsigned long addr, int numpages)
>  }
>  
>  static int __set_memory_enc_dec(unsigned long addr, int numpages, bool enc)
> +{
> +	return static_call(x86_set_memory_enc)(addr, numpages, enc);
> +}
> +
> +static int default_set_memory_enc(unsigned long addr, int numpages, bool enc)
>  {
>  	struct cpa_data cpa;
>  	int ret;

It doesn't make a lot of difference to add this infrastructure and then
ignore it for the existing in-tree user:

> static int __set_memory_enc_dec(unsigned long addr, int numpages, bool enc)
> {
>         struct cpa_data cpa;
>         int ret;
> 
>         /* Nothing to do if memory encryption is not active */
>         if (!mem_encrypt_active())
>                 return 0;

Shouldn't the default be to just "return 0"?  Then on
mem_encrypt_active() systems, do the bulk of what is in
__set_memory_enc_dec() today.


  reply	other threads:[~2021-08-04 19:27 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04 18:44 [PATCH V2 00/14] x86/Hyper-V: Add Hyper-V Isolation VM support Tianyu Lan
2021-08-04 18:44 ` [PATCH V2 01/14] x86/HV: Initialize GHCB page in Isolation VM Tianyu Lan
2021-08-04 18:44 ` [PATCH V2 02/14] x86/HV: Initialize shared memory boundary in the " Tianyu Lan
2021-08-04 18:44 ` [PATCH V2 03/14] x86/set_memory: Add x86_set_memory_enc static call support Tianyu Lan
2021-08-04 19:27   ` Dave Hansen [this message]
2021-08-05 14:05     ` Tianyu Lan
2021-08-05 14:11       ` Peter Zijlstra
2021-08-05 14:23       ` Peter Zijlstra
2021-08-05 14:29         ` Dave Hansen
2021-08-05 15:51           ` Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 04/14] x86/HV: Add new hvcall guest address host visibility support Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 05/14] HV: Mark vmbus ring buffer visible to host in Isolation VM Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 06/14] HV: Add Write/Read MSR registers via ghcb page Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 07/14] HV: Add ghcb hvcall support for SNP VM Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 08/14] HV/Vmbus: Add SNP support for VMbus channel initiate message Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 09/14] HV/Vmbus: Initialize VMbus ring buffer for Isolation VM Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 10/14] DMA: Add dma_map_decrypted/dma_unmap_encrypted() function Tianyu Lan
2021-08-05 15:56   ` Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 11/14] x86/Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM Tianyu Lan
2021-08-05 16:01   ` Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 12/14] HV/IOMMU: Enable swiotlb bounce buffer for Isolation VM Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 13/14] HV/Netvsc: Add Isolation VM support for netvsc driver Tianyu Lan
2021-08-04 18:45 ` [PATCH V2 14/14] HV/Storvsc: Add Isolation VM support for storvsc driver Tianyu Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5823af8a-7dbb-dbb0-5ea2-d9846aa2a36a@intel.com \
    --to=dave.hansen@intel$(echo .)com \
    --cc=Tianyu.Lan@microsoft$(echo .)com \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=aneesh.kumar@linux$(echo .)ibm.com \
    --cc=ardb@kernel$(echo .)org \
    --cc=arnd@arndb$(echo .)de \
    --cc=boris.ostrovsky@oracle$(echo .)com \
    --cc=bp@alien8$(echo .)de \
    --cc=brijesh.singh@amd$(echo .)com \
    --cc=dave.hansen@linux$(echo .)intel.com \
    --cc=davem@davemloft$(echo .)net \
    --cc=david@redhat$(echo .)com \
    --cc=decui@microsoft$(echo .)com \
    --cc=haiyangz@microsoft$(echo .)com \
    --cc=hch@lst$(echo .)de \
    --cc=hpa@zytor$(echo .)com \
    --cc=iommu@lists$(echo .)linux-foundation.org \
    --cc=jejb@linux$(echo .)ibm.com \
    --cc=jgross@suse$(echo .)com \
    --cc=joro@8bytes$(echo .)org \
    --cc=keescook@chromium$(echo .)org \
    --cc=kirill.shutemov@linux$(echo .)intel.com \
    --cc=konrad.wilk@oracle$(echo .)com \
    --cc=krish.sadhukhan@oracle$(echo .)com \
    --cc=kuba@kernel$(echo .)org \
    --cc=kys@microsoft$(echo .)com \
    --cc=linux-arch@vger$(echo .)kernel.org \
    --cc=linux-hyperv@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-scsi@vger$(echo .)kernel.org \
    --cc=ltykernel@gmail$(echo .)com \
    --cc=luto@kernel$(echo .)org \
    --cc=m.szyprowski@samsung$(echo .)com \
    --cc=martin.b.radev@gmail$(echo .)com \
    --cc=martin.petersen@oracle$(echo .)com \
    --cc=michael.h.kelley@microsoft$(echo .)com \
    --cc=mingo@redhat$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=parri.andrea@gmail$(echo .)com \
    --cc=peterz@infradead$(echo .)org \
    --cc=pgonda@google$(echo .)com \
    --cc=rientjes@google$(echo .)com \
    --cc=robin.murphy@arm$(echo .)com \
    --cc=rppt@kernel$(echo .)org \
    --cc=saravanand@fb$(echo .)com \
    --cc=sstabellini@kernel$(echo .)org \
    --cc=sthemmin@microsoft$(echo .)com \
    --cc=tglx@linutronix$(echo .)de \
    --cc=thomas.lendacky@amd$(echo .)com \
    --cc=tj@kernel$(echo .)org \
    --cc=vkuznets@redhat$(echo .)com \
    --cc=wei.liu@kernel$(echo .)org \
    --cc=will@kernel$(echo .)org \
    --cc=x86@kernel$(echo .)org \
    --cc=xen-devel@lists$(echo .)xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox