From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: David Lebrun <david.lebrun@uclouvain•be>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail•com>,
David Miller <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Lorenzo Colitti <lorenzo@google•com>,
Eric Dumazet <eric.dumazet@gmail•com>
Subject: Re: [PATCH net-next 1/1] ipv6: sr: add option to control lwtunnel support
Date: Wed, 23 Nov 2016 06:57:44 -0800 [thread overview]
Message-ID: <5835AE68.3060003@cumulusnetworks.com> (raw)
In-Reply-To: <5835613D.8070104@uclouvain.be>
On 11/23/16, 1:28 AM, David Lebrun wrote:
> On 11/23/2016 08:34 AM, Roopa Prabhu wrote:
>> I can't seem to reproduce the problem you are seeing. still trying..
>> I don't have CONFIG_LWTUNNEL set nor any of the other SEG6 configs.
>> My CONFIG_IPV6 is on and compiled as a module. I have also tried disabling it.
>> If you can send me the config, I can try again. Looking back at the patches,
>> I do see a few things below ..but they may not fix your problem directly.
>>
>> Though I had none of the ipv6 segment routing configs turned on,
>> I do see the "Segment Routing with IPv6" msg at bootup.
>> Was looking at david's patches again, and a few things (I had missed seeing the last version):
>>
>> In my review comment I was hinting at CONFIG_IPV6_SEG6 to cover all of ipv6 segment routing,
>> including the lwtunnel bits.
>>
>> something like below:
>>
>> config IPV6_SEG6
>> bool "IPv6: Segment Routing Header encapsulation support"
>> depends on LWTUNNEL && IPV6
>>
>> DavidL, do you see a problem doing it this way ?. with this 'seg6.o' will be part of CONFIG_IPV6_SEG6 and not
>> get initialized unless it is enabled..which seems like the right thing to do.
> Can't reproduce the bug either, with CONFIG_IPV6=y, LWTUNNEL=n and all
> SEG6 disabled. Alexei, your .config and dmesg log could help.
>
> Roopa, the reason why seg6.o is compiled by default is that it provides
> an interface to control HMAC structures, and that HMAC does not depends
> on lwtunnels and can be used in the extension header processing (which
> is compiled by default). I could indeed add another option to
> conditionnally compile seg6.o if HMAC is enabled etc, and I actually had
> something like that in the very first versions of the patch, but I
> received comments that too much options is not a good thing (and I agree
> with that).
okay then. I agree with not having too many option. I had just thought that it
could live with the existing CONFIG_IPV6_SEG6_LWTUNNEL if it was renamed.
had not looked at the HMAC dependency.
next prev parent reply other threads:[~2016-11-23 14:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 0:16 [PATCH net-next 1/1] ipv6: sr: add option to control lwtunnel support Alexei Starovoitov
2016-11-23 7:34 ` Roopa Prabhu
2016-11-23 9:28 ` David Lebrun
2016-11-23 14:57 ` Roopa Prabhu [this message]
2016-11-24 2:31 ` Alexei Starovoitov
-- strict thread matches above, loose matches on Subject: below --
2016-11-15 15:14 David Lebrun
2016-11-16 16:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5835AE68.3060003@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=david.lebrun@uclouvain$(echo .)be \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=lorenzo@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox