From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: Zhang Shengju <zhangshengju@cmss•chinamobile.com>
Cc: netdev@vger•kernel.org, davem@davemloft•net
Subject: Re: [net] rtnetlink: fix the wrong minimal dump size getting from rtnl_calcit()
Date: Wed, 23 Nov 2016 07:38:53 -0800 [thread overview]
Message-ID: <5835B80D.80307@cumulusnetworks.com> (raw)
In-Reply-To: <1479795268-11801-1-git-send-email-zhangshengju@cmss.chinamobile.com>
On 11/21/16, 10:14 PM, Zhang Shengju wrote:
> For RT netlink, calcit() function should return the minimal size for
> netlink dump message. This will make sure that dump message for every
> network device can be stored.
>
> Currently, rtnl_calcit() function doesn't account the size of header of
> netlink message, this patch will fix it.
>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss•chinamobile.com>
> ---
> net/core/rtnetlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index f4b9350..09e115b 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -2734,7 +2734,7 @@ static u16 rtnl_calcit(struct sk_buff *skb, struct nlmsghdr *nlh)
> ext_filter_mask));
> }
>
> - return min_ifinfo_dump_size;
> + return nlmsg_total_size(min_ifinfo_dump_size);
> }
>
> static int rtnl_dump_all(struct sk_buff *skb, struct netlink_callback *cb)
This looks fine to me. However, looking at the git log, since this code has been
around for so long, it seems like it can go into net-next. But, that's just my 2c.
next prev parent reply other threads:[~2016-11-23 15:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 6:14 [net] rtnetlink: fix the wrong minimal dump size getting from rtnl_calcit() Zhang Shengju
2016-11-23 15:38 ` Roopa Prabhu [this message]
2016-11-24 1:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5835B80D.80307@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=zhangshengju@cmss$(echo .)chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox