public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Timur Tabi <timur@codeaurora•org>
To: Florian Fainelli <f.fainelli@gmail•com>,
	David Miller <davem@davemloft•net>,
	jon.mason@broadcom•com, netdev@vger•kernel.org
Subject: Re: [PATCH] [v3] net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause
Date: Tue, 6 Dec 2016 20:54:59 -0600	[thread overview]
Message-ID: <58477A03.6000107@codeaurora.org> (raw)
In-Reply-To: <f62595d4-2dd7-9cc3-7537-2ff186dadc8c@gmail.com>

Florian Fainelli wrote:
> which is why this made me think the & (SUPPORTED_Pause |
> SUPPPORTED_Asym_Pause) here is most likely redundant?

Well, like I said, better safe than sorry.  I'd rather keep the &= 
unless you have a strong objection.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.

  reply	other threads:[~2016-12-07  2:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-07  0:27 [PATCH] [v3] net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause Timur Tabi
2016-12-07  0:36 ` Florian Fainelli
2016-12-07  1:50   ` Timur Tabi
2016-12-07  1:57     ` Florian Fainelli
2016-12-07  2:54       ` Timur Tabi [this message]
2016-12-07  9:13         ` Niklas Cassel
2016-12-07 17:19           ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58477A03.6000107@codeaurora.org \
    --to=timur@codeaurora$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=f.fainelli@gmail$(echo .)com \
    --cc=jon.mason@broadcom$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox