From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: Nogah Frankel <nogahf@mellanox•com>
Cc: netdev@vger•kernel.org, stephen@networkplumber•org,
roszenrami@gmail•com, ogerlitz@mellanox•com, jiri@mellanox•com,
eladr@mellanox•com, yotamg@mellanox•com, idosch@mellanox•com
Subject: Re: [PATCH iproute2 v3 4/4] ifstat: Add "sw only" extended statistics to ifstat
Date: Thu, 22 Dec 2016 13:10:19 -0800 [thread overview]
Message-ID: <585C413B.9050905@cumulusnetworks.com> (raw)
In-Reply-To: <1482423795-6531-5-git-send-email-nogahf@mellanox.com>
On 12/22/16, 8:23 AM, Nogah Frankel wrote:
> Add support for extended statistics of SW only type, for counting only the
> packets that went via the cpu. (useful for systems with forward
> offloading). It reads it from filter type IFLA_STATS_LINK_OFFLOAD_XSTATS
> and sub type IFLA_OFFLOAD_XSTATS_CPU_HIT.
>
> It is under the name 'software'
> (or any shorten of it as 'soft' or simply 's')
>
> For example:
> ifstat -x s
>
>
Nogah, can we keep the option names closer to the attribute names ?
That would avoid some confusion and help with the follow-up stats.
ifstat -x offload cpu
or
ifstat -x cpu
for others it would be:
ifstat -x link [vlan|igmp]
ifstat -x vlan
ifstat -x igmp
ifstat -x lacp
and so on...
thanks!
next prev parent reply other threads:[~2016-12-22 21:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 16:23 [PATCH iproute2 v3 0/4] update ifstat for new stats Nogah Frankel
2016-12-22 16:23 ` [PATCH iproute2 v3 1/4] ifstat: Includes reorder Nogah Frankel
2016-12-22 16:23 ` [PATCH iproute2 v3 2/4] ifstat: Add extended statistics to ifstat Nogah Frankel
2016-12-22 18:59 ` Stephen Hemminger
2016-12-25 10:25 ` Nogah Frankel
2016-12-22 16:23 ` [PATCH iproute2 v3 3/4] ifstat: Add 64 bits based stats to extended statistics Nogah Frankel
2016-12-22 16:23 ` [PATCH iproute2 v3 4/4] ifstat: Add "sw only" extended statistics to ifstat Nogah Frankel
2016-12-22 21:10 ` Roopa Prabhu [this message]
2016-12-25 11:23 ` Nogah Frankel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=585C413B.9050905@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=eladr@mellanox$(echo .)com \
--cc=idosch@mellanox$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nogahf@mellanox$(echo .)com \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=roszenrami@gmail$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=yotamg@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox