Subject: Re: [PATCH net-next 0/6] Prepare BPF for VLAN_TAG_PRESENT cleanup

From: Daniel Borkmann <[email-masked]>
Date: Wed, 04 Jan 2017 21:11:57 +0100

On 01/04/2017 02:18 AM, Michał Mirosław wrote:
> Those patches prepare BPF ant its JITs for removal of VLAN_TAG_PRESENT.
> The set depends on "Preparation for VLAN_TAG_PRESENT cleanup" patchset.
>
> The series is supposed to be bisect-friendly and that requires temporary
> insertion of #define VLAN_TAG_PRESENT in BPF code to be able to split
> JIT changes per architecture.
>
> Michał Mirosław (6):
>    net/skbuff: add macros for VLAN_PRESENT bit
>    net/bpf_jit: ARM: split VLAN_PRESENT bit handling from VLAN_TCI
>    net/bpf_jit: MIPS: split VLAN_PRESENT bit handling from VLAN_TCI
>    net/bpf_jit: PPC: split VLAN_PRESENT bit handling from VLAN_TCI
>    net/bpf_jit: SPARC: split VLAN_PRESENT bit handling from VLAN_TCI
>    net/bpf: split VLAN_PRESENT bit handling from VLAN_TCI

Please add a proper changelog to all the individual patches, right now
they have none. Also, how was this runtime tested? Did you run BPF selftest
suite with them? Seems like they weren't even compile tested properly
given the kbuild bot barking on sparc ...

>   arch/arm/net/bpf_jit_32.c       | 16 ++++++++++------
>   arch/mips/net/bpf_jit.c         | 18 ++++++++++--------
>   arch/powerpc/net/bpf_jit_comp.c | 17 +++++++++--------
>   arch/sparc/net/bpf_jit_comp.c   | 18 ++++++++++--------
>   include/linux/skbuff.h          |  6 ++++++
>   net/core/filter.c               | 19 +++++++++----------
>   6 files changed, 54 insertions(+), 40 deletions(-)
>