From: John Fastabend <john.fastabend@gmail•com>
To: Jiri Pirko <jiri@resnulli•us>, Jamal Hadi Salim <jhs@mojatatu•com>
Cc: Paul Blakey <paulb@mellanox•com>,
"David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org, Jiri Pirko <jiri@mellanox•com>,
Hadar Hen Zion <hadarh@mellanox•com>,
Or Gerlitz <ogerlitz@mellanox•com>, Roi Dayan <roid@mellanox•com>,
Roman Mashak <mrv@mojatatu•com>,
Simon Horman <simon.horman@netronome•com>
Subject: Re: [PATCH net-next] net/sched: cls_flower: Add user specified data
Date: Mon, 9 Jan 2017 10:23:31 -0800 [thread overview]
Message-ID: <5873D523.4030301@gmail.com> (raw)
In-Reply-To: <20170108171902.GH1971@nanopsycho>
On 17-01-08 09:19 AM, Jiri Pirko wrote:
> Mon, Jan 02, 2017 at 11:21:41PM CET, jhs@mojatatu•com wrote:
>> On 17-01-02 01:23 PM, John Fastabend wrote:
>>
>>>
>>> Additionally I would like to point out this is an arbitrary length binary
>>> blob (for undefined use, without even a specified encoding) that gets pushed
>>> between user space and hardware ;) This seemed to get folks fairly excited in
>>> the past.
>>>
>>
>> The binary blob size is a little strange - but i think there is value
>> in storing some "cookie" field. The challenge is whether the kernel
>> gets to intepret it; in which case encoding must be specified. Or
>> whether we should leave it up to user space - in which something
>> like tc could standardize its own encodings.
>
> This should never be interpreted by kernel. I think this would be good
> to make clear in the comment in the code.
>
Ah OK I had assumed you would be pushing this via tc_cls_flower_offload into
the driver in a follow up patch. But if it lives in kernel space as opaque
cookie guess its no different then other id fields order/prio/cookie.
Thanks for clarifying.
next prev parent reply other threads:[~2017-01-09 18:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 13:13 [PATCH net-next] net/sched: cls_flower: Add user specified data Paul Blakey
2017-01-02 14:59 ` Jamal Hadi Salim
2017-01-02 18:23 ` John Fastabend
2017-01-02 22:21 ` Jamal Hadi Salim
2017-01-02 22:58 ` John Fastabend
2017-01-03 1:22 ` Jamal Hadi Salim
2017-01-03 4:33 ` John Fastabend
2017-01-03 11:44 ` Jamal Hadi Salim
2017-01-03 12:22 ` Paul Blakey
2017-01-04 10:14 ` Simon Horman
2017-01-04 11:45 ` Paul Blakey
2017-01-05 8:03 ` Simon Horman
2017-01-14 13:06 ` Jamal Hadi Salim
2017-01-08 17:19 ` Jiri Pirko
2017-01-09 18:23 ` John Fastabend [this message]
2017-01-14 12:56 ` Jamal Hadi Salim
2017-01-14 14:48 ` Jiri Pirko
2017-01-14 15:03 ` Jamal Hadi Salim
2017-01-14 15:29 ` Jiri Pirko
2017-01-14 17:46 ` Jamal Hadi Salim
2017-01-08 17:15 ` Jiri Pirko
2017-01-08 17:12 ` Jiri Pirko
2017-01-15 17:36 ` Paul Blakey
2017-01-15 19:08 ` John Fastabend
2017-01-16 7:54 ` Paul Blakey
2017-01-16 9:51 ` Jiri Pirko
2017-01-17 11:23 ` Jamal Hadi Salim
2017-01-17 11:53 ` Paul Blakey
2017-01-18 11:06 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5873D523.4030301@gmail.com \
--to=john.fastabend@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=hadarh@mellanox$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=mrv@mojatatu$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=paulb@mellanox$(echo .)com \
--cc=roid@mellanox$(echo .)com \
--cc=simon.horman@netronome$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox