From: Daniel Borkmann <daniel@iogearbox•net>
To: Quentin Monnet <quentin.monnet@6wind•com>, davem@davemloft•net
Cc: alexei.starovoitov@gmail•com, netdev@vger•kernel.org
Subject: Re: [PATCH net-next 2/2] bpf: allow b/h/w/dw access for bpf's cb in ctx
Date: Thu, 12 Jan 2017 11:53:10 +0100 [thread overview]
Message-ID: <58776016.1050303@iogearbox.net> (raw)
In-Reply-To: <bb078a63-6bcc-22f8-c98e-8445f66678c9@6wind.com>
On 01/12/2017 09:25 AM, Quentin Monnet wrote:
> 2017-01-12 (02:21 +0100) ~ Daniel Borkmann <daniel@iogearbox•net>
[...]
>> diff --git a/tools/testing/selftests/bpf/test_verifier.c b/tools/testing/selftests/bpf/test_verifier.c
>> index 9bb4534..f664bed 100644
>> --- a/tools/testing/selftests/bpf/test_verifier.c
>> +++ b/tools/testing/selftests/bpf/test_verifier.c
>> @@ -859,15 +859,451 @@ struct test_val {
>
> [...]
>
>> + {
>> + "check cb access: doulbe, oob 5",
>> + .insns = {
>> + BPF_MOV64_IMM(BPF_REG_0, 0),
>> + BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_1,
>> + offsetof(struct __sk_buff, cb[4]) + 8),
>> + BPF_EXIT_INSN(),
>> + },
>> + .errstr = "invalid bpf_context access",
>> + .result = REJECT,
>> + },
>
> Nitpicking: typo ("doulbe").
Thanks for spotting, I've sent out a v2.
prev parent reply other threads:[~2017-01-12 11:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 1:21 [PATCH net-next 0/2] More flexible BPF cb access Daniel Borkmann
2017-01-12 1:21 ` [PATCH net-next 1/2] bpf: pass original insn directly to convert_ctx_access Daniel Borkmann
2017-01-12 1:21 ` [PATCH net-next 2/2] bpf: allow b/h/w/dw access for bpf's cb in ctx Daniel Borkmann
2017-01-12 8:25 ` Quentin Monnet
2017-01-12 10:53 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58776016.1050303@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=quentin.monnet@6wind$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox