From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: Robert Shearman <rshearma@brocade•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org,
David Ahern <dsa@cumulusnetworks•com>,
ebiederm@xmission•com
Subject: Re: [PATCH net-next 2/2] mpls: Packet stats
Date: Fri, 13 Jan 2017 14:51:08 -0800 [thread overview]
Message-ID: <587959DC.9020403@cumulusnetworks.com> (raw)
In-Reply-To: <1484331253-5908-3-git-send-email-rshearma@brocade.com>
On 1/13/17, 10:14 AM, Robert Shearman wrote:
> Having MPLS packet stats is useful for observing network operation and
> for diagnosing network problems. In the absence of anything better,
> RFC2863 and RFC3813 are used for guidance for which stats to expose
> and the semantics of them. In particular rx_noroutes maps to in
> unknown protos in RFC2863. The stats are exposed to userspace via
> AF_MPLS attributes embedded in the IFLA_STATS_AF_SPEC attribute of
> RTM_GETSTATS messages.
>
> All the introduced fields are 64-bit, even error ones, to ensure no
> overflow with long uptimes. Per-CPU counters are used to avoid
> cache-line contention on the commonly used fields. The other fields
> have also been made per-CPU for code to avoid performance problems in
> error conditions on the assumption that on some platforms the cost of
> atomic operations could be more expensive than sending the packet
> (which is what would be done in the success case). If that's not the
> case, we could instead not use per-CPU counters for these fields.
>
> Only unicast and non-fragment are exposed at the moment, but other
> counters can be exposed in the future either by adding to the end of
> struct mpls_link_stats or by additional netlink attributes in the
> AF_MPLS IFLA_STATS_AF_SPEC nested attribute.
>
> Signed-off-by: Robert Shearman <rshearma@brocade•com>
> ---
>
Acked-by: Roopa Prabhu <roopa@cumulusnetworks•com>
next prev parent reply other threads:[~2017-01-13 22:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 18:14 [PATCH net-next 0/2] mpls: Packet stats Robert Shearman
2017-01-13 18:14 ` [PATCH net-next 1/2] net: AF-specific RTM_GETSTATS attributes Robert Shearman
2017-01-13 22:50 ` Roopa Prabhu
2017-01-13 18:14 ` [PATCH net-next 2/2] mpls: Packet stats Robert Shearman
2017-01-13 22:51 ` Roopa Prabhu [this message]
2017-01-14 6:41 ` kbuild test robot
2017-01-16 10:30 ` Robert Shearman
2017-01-14 6:58 ` kbuild test robot
2017-01-13 22:50 ` [PATCH net-next 0/2] " Roopa Prabhu
2017-01-16 14:16 ` [PATCH net-next v2 " Robert Shearman
2017-01-16 14:16 ` [PATCH net-next v2 1/2] net: AF-specific RTM_GETSTATS attributes Robert Shearman
2017-01-16 14:16 ` [PATCH net-next v2 2/2] mpls: Packet stats Robert Shearman
2017-01-17 19:39 ` [PATCH net-next v2 0/2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=587959DC.9020403@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsa@cumulusnetworks$(echo .)com \
--cc=ebiederm@xmission$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rshearma@brocade$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox