From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: Nogah Frankel <nogahf@mellanox•com>
Cc: Stephen Hemminger <stephen@networkplumber•org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"roszenrami@gmail•com" <roszenrami@gmail•com>,
Jiri Pirko <jiri@mellanox•com>,
Ido Schimmel <idosch@mellanox•com>, Elad Raz <eladr@mellanox•com>,
Yotam Gigi <yotamg@mellanox•com>,
Or Gerlitz <ogerlitz@mellanox•com>
Subject: Re: [PATCH iproute2 v4 3/4] ifstat: Add 64 bits based stats to extended statistics
Date: Thu, 19 Jan 2017 08:06:21 -0800 [thread overview]
Message-ID: <5880E3FD.6010604@cumulusnetworks.com> (raw)
In-Reply-To: <DB5PR05MB1895D7CFBE9E127AAAE672DBAC7E0@DB5PR05MB1895.eurprd05.prod.outlook.com>
On 1/19/17, 7:21 AM, Nogah Frankel wrote:
>> -----Original Message-----
>> From: Nogah Frankel
>> Sent: Sunday, January 15, 2017 3:55 PM
>> To: 'Stephen Hemminger' <stephen@networkplumber•org>
>> Cc: netdev@vger•kernel.org; roszenrami@gmail•com; roopa@cumulusnetworks•com; Jiri
>> Pirko <jiri@mellanox•com>; Ido Schimmel <idosch@mellanox•com>; Elad Raz
>> <eladr@mellanox•com>; Yotam Gigi <yotamg@mellanox•com>; Or Gerlitz
>> <ogerlitz@mellanox•com>
>> Subject: RE: [PATCH iproute2 v4 3/4] ifstat: Add 64 bits based stats to extended statistics
>>
>>
>>
>>> -----Original Message-----
>>> From: Stephen Hemminger [mailto:stephen@networkplumber•org]
>>> Sent: Friday, January 13, 2017 3:44 AM
>>> To: Nogah Frankel <nogahf@mellanox•com>
>>> Cc: netdev@vger•kernel.org; roszenrami@gmail•com; roopa@cumulusnetworks•com;
>> Jiri
>>> Pirko <jiri@mellanox•com>; Ido Schimmel <idosch@mellanox•com>; Elad Raz
>>> <eladr@mellanox•com>; Yotam Gigi <yotamg@mellanox•com>; Or Gerlitz
>>> <ogerlitz@mellanox•com>
>>> Subject: Re: [PATCH iproute2 v4 3/4] ifstat: Add 64 bits based stats to extended statistics
>>>
>>> On Thu, 12 Jan 2017 15:49:50 +0200
>>> Nogah Frankel <nogahf@mellanox•com> wrote:
>>>
>>>> The default stats for ifstat are 32 bits based.
>>>> The kernel supports 64 bits based stats. (They are returned in struct
>>>> rtnl_link_stats64 which is an exact copy of struct rtnl_link_stats, in
>>>> which the "normal" stats are returned, but with fields of u64 instead of
>>>> u32). This patch adds them as an extended stats.
>>>>
>>>> It is read with filter type IFLA_STATS_LINK_64 and no sub type.
>>>>
>>>> It is under the name 64bits
>>>> (or any shorten of it as "64")
>>>>
>>>> For example:
>>>> ifstat -x 64bit
>>>>
>>>> Signed-off-by: Nogah Frankel <nogahf@mellanox•com>
>>>> Reviewed-by: Jiri Pirko <jiri@mellanox•com>
>>> Other commands (like ip link) always use the 64 bit statistics if available
>>> from the device. I see no reason that ifstat needs to be different.
>>>
>> Do you mean to change the default ifstat results to be 64 bits based?
>> I tried it in the first version, but Roopa commented that it was not a good idea.
>> She said they tried it in the past and it caused backward compatibilities problems.
>> (Or maybe I didn't understand correctly)
> So, can I leave the default ifstat results to be 32 bits based, for the time being?
>
>From past discussions: Moving the default to 64bit has compat issues with the old history file.
There is a way to make it work by using a new file header (to indicate that it is 64 bit) in
a freshly created history file and also check this header before dumping stats into the history file.
ie maintain backward compat without introducing a new option. It is doable.
One approach is, you can drop the 64bit option from this series and
try updating the default to 64 bit (with compat handling code) in a later series.
next prev parent reply other threads:[~2017-01-19 16:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 13:49 [PATCH iproute2 v4 0/4] update ifstat for new stats Nogah Frankel
2017-01-12 13:49 ` [PATCH iproute2 v4 1/4] ifstat: Includes reorder Nogah Frankel
2017-01-13 10:10 ` Sergei Shtylyov
2017-01-15 13:49 ` Nogah Frankel
2017-01-12 13:49 ` [PATCH iproute2 v4 2/4] ifstat: Add extended statistics to ifstat Nogah Frankel
2017-01-12 13:49 ` [PATCH iproute2 v4 3/4] ifstat: Add 64 bits based stats to extended statistics Nogah Frankel
2017-01-13 1:43 ` Stephen Hemminger
2017-01-15 13:54 ` Nogah Frankel
2017-01-19 15:21 ` Nogah Frankel
2017-01-19 16:06 ` Roopa Prabhu [this message]
2017-01-19 19:11 ` Stephen Hemminger
2017-01-22 15:34 ` Nogah Frankel
2017-01-12 13:49 ` [PATCH iproute2 v4 4/4] ifstat: Add "sw only" extended statistics to ifstat Nogah Frankel
2017-01-12 15:32 ` [PATCH iproute2 v4 0/4] update ifstat for new stats Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5880E3FD.6010604@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=eladr@mellanox$(echo .)com \
--cc=idosch@mellanox$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nogahf@mellanox$(echo .)com \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=roszenrami@gmail$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=yotamg@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox