Subject: Re: iproute2: using .maxattr = IFLA_VLAN_MAX??

From: Murali Karicheri <[email-masked]>
Date: Thu, 26 Jan 2017 11:27:41 -0500

On 01/23/2017 03:45 PM, Rosen, Rami wrote:
> Hi, Murali,
> 
>> This appears to be a cut-n-paste bug as the source is based on ip/iplink_vlan.c and should be fixed to IFLA_HSR_MAX. 
> 
> You are right.
> The "HSR section" indeed defines IFLA_HSR_MAX in include/linux/if_link.h of iproute2 as the max attributes number.
> 
> And in the top of ip/iplink_hsr.c you will find this comment, which enhances your assumption about the origin of this mistake:
> 
> /*
> ...
>      Based on iplink_vlan.c by Patrick McHardy <[email-masked]
> ...
>  */
> 
> Regards,
> Rami Rosen
> 
Hi, Rami,

Thanks for confirming. I will send out a patch for fixing this when I get a chance to 
test hsr for my work in the next few days.

-- 
Murali Karicheri
Linux Kernel, Keystone