Subject: Re: [PATCH net-next 2/2] Add a eBPF helper function to retrieve socket uid

From: Daniel Borkmann <[email-masked]>
Date: Fri, 03 Feb 2017 01:28:31 +0100

On 02/03/2017 01:00 AM, Lorenzo Colitti wrote:
> On Fri, Feb 3, 2017 at 6:32 AM, Daniel Borkmann <[email-masked]> wrote:
>>> +       sk = skb->sk;
>>> +       kuid = sock_net_uid(dev_net(skb->dev), sk);
>>
>> Don't you need to test for fullsock? Do you mean something like below?
>
> It should be safe to call sock_net_uid on any type of socket
> (including NULL). sk_uid was added to struct sock in 86741ec25462
> ("net: core: Add a UID field to struct sock.")

Hmm, maybe I'm missing something, but then shouldn't this sit in
struct sock_common for being 'safe'? F.e. struct inet_timewait_sock
wouldn't have it ...