From: Daniel Borkmann <daniel@iogearbox•net>
To: William Tu <u9012063@gmail•com>,
Alexei Starovoitov <alexei.starovoitov@gmail•com>
Cc: Linux Kernel Network Developers <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next] bpf: fix verifier issue at check_packet_ptr_add
Date: Fri, 03 Feb 2017 09:37:08 +0100 [thread overview]
Message-ID: <58944134.6060107@iogearbox.net> (raw)
In-Reply-To: <CALDO+SZrm3KpDDRrC6H9jkaMVxiwUPEFp+1vBaZbSvTdH8=09w@mail.gmail.com>
On 02/03/2017 06:31 AM, William Tu wrote:
[...]
> Yes, this is auto-generated. We want to use P4 2016 as front end to
> generate ebpf for XDP.
>
[...]
> R2 is no longer pkt_end, it's R2 == R0 == 0
> 269: (bf) r2 = r0
> 270: (77) r2 >>= 3
> 271: (bf) r4 = r1
> 272: (0f) r4 += r2
>
> So at line 272, it's pkt_ptr = pkt_ptr + 0
> thus the following fix works for us.
> - if (imm <= 0) {
> + if (imm < 0) {
Okay, makes sense. I'll wait with ACK for your respin with kselftest
case.
Thanks,
Daniel
prev parent reply other threads:[~2017-02-03 8:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 19:59 [PATCH net-next] bpf: fix verifier issue at check_packet_ptr_add William Tu
2017-02-02 23:46 ` Daniel Borkmann
2017-02-03 3:26 ` William Tu
2017-02-03 3:46 ` Alexei Starovoitov
2017-02-03 5:31 ` William Tu
2017-02-03 6:19 ` Alexei Starovoitov
2017-02-03 16:20 ` William Tu
2017-02-03 8:37 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58944134.6060107@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=u9012063@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox