From: Dongpo Li <lidongpo@hisilicon•com>
To: Marty Plummer <netz.kernel@gmail•com>, <netdev@vger•kernel.org>
Cc: <yisen.zhuang@huawei•com>, <salil.mehta@huawei•com>
Subject: Re: net: hix5hd2_gmac uninitialized net_device
Date: Fri, 10 Feb 2017 18:21:35 +0800 [thread overview]
Message-ID: <589D942F.7070700@hisilicon.com> (raw)
In-Reply-To: <20170210074544.eoabpjf522pmwoui@tha-monstah.mydomain>
On 2017/2/10 15:45, Marty Plummer wrote:
> On Fri, Feb 10, 2017 at 01:41:18AM -0600, Marty Plummer wrote:
>> Greetings.
>>
>> I think I may have found a bug with the hix5hd2_gmac driver; unless I'm
>> missing something, it appears that somehow the net_device struct is not
>> being initialized properly in the hix5hd2_dev_probe function.
>>
>> Having set up my devicetree properly (I hope, still new to this), I first
>> recieved an error when inserting the module:
>> "(unnamed net_device) (uninitialized): No irq resource"
>> while I very clearly have the interrupts property defined within this node.
>>
I think the error "No irq resource" happened for some other reason, has no relation with
the info "(unnamed net_device) (uninitialized):".
You can add more debug info to find bug.
>> Removing the phy-handle node for testing purposes, I get a similar message:
>> "(unnamed net_device) (uninitialized): not find phy-handle"
>>
>> So, it seams to my (admittedly inexperienced) mind that the ndev pointer is
>> not being initialized properly, or that the error checking at line 1111
>> is not functioning properly either, for it to have gotten so far along
>> into the function, only to fail at the attempt to access the ndev pointer.
>>
Yes, I agree with you that the ndev has not been initialized completely,
because the function "register_netdev" has not been called yet.
It's better to use the "dev_err" to replace the "netdev_err".
>> If you require more information from me, please let me know.
>>
>> Marty
>
> Sorry, forgot the subject. Still getting the hang of mutt.
>
>
Regards,
Dongpo
.
next prev parent reply other threads:[~2017-02-10 10:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 7:41 (unknown) Marty Plummer
2017-02-10 7:45 ` net: hix5hd2_gmac uninitialized net_device Marty Plummer
2017-02-10 10:21 ` Dongpo Li [this message]
2017-02-11 0:51 ` Marty Plummer
2017-02-13 1:25 ` Dongpo Li
2017-02-14 23:59 ` Marty Plummer
2017-02-15 6:18 ` Dongpo Li
2017-02-16 18:45 ` Marty Plummer
2017-02-17 1:32 ` Dongpo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=589D942F.7070700@hisilicon.com \
--to=lidongpo@hisilicon$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netz.kernel@gmail$(echo .)com \
--cc=salil.mehta@huawei$(echo .)com \
--cc=yisen.zhuang@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox