From: Alexei Starovoitov <ast@fb•com>
To: David Miller <davem@davemloft•net>
Cc: <daniel@iogearbox•net>, <daniel@zonque•org>, <dvyukov@google•com>,
<netdev@vger•kernel.org>
Subject: Re: [PATCH net] bpf: add get_next_key callback to LPM map
Date: Sun, 5 Mar 2017 10:58:00 -0800 [thread overview]
Message-ID: <58BC5FB8.4090507@fb.com> (raw)
In-Reply-To: <20170305.104413.1645369685777679734.davem@davemloft.net>
On 3/5/17 10:44 AM, David Miller wrote:
> From: Alexei Starovoitov <ast@fb•com>
> Date: Sun, 5 Mar 2017 09:41:08 -0800
>
>> map_get_next_key callback is mandatory. Supply dummy handler.
>>
>> Fixes: b95a5c4db09b ("bpf: add a longest prefix match trie map implementation")
>> Reported-by: Dmitry Vyukov <dvyukov@google•com>
>> Signed-off-by: Alexei Starovoitov <ast@kernel•org>
>
> Wouldn't it be more appropriate to provide a proper DFS ordered
> traversal rather than return an error code?
yes. of course. This is quick fix for 'net'.
That's why the error code is ENOTSUPP with meaning that
it's not supported right now and will be supported in the future.
next prev parent reply other threads:[~2017-03-05 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-05 17:41 [PATCH net] bpf: add get_next_key callback to LPM map Alexei Starovoitov
2017-03-05 18:44 ` David Miller
2017-03-05 18:58 ` Alexei Starovoitov [this message]
2017-03-06 1:55 ` David Miller
2017-03-06 9:30 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58BC5FB8.4090507@fb.com \
--to=ast@fb$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=daniel@zonque$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dvyukov@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox