public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: Robert Shearman <rshearma@brocade•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org,
	"Eric W. Biederman" <ebiederm@xmission•com>,
	David Ahern <dsa@cumulusnetworks•com>
Subject: Re: [PATCH net-next v3 0/2] mpls: allow TTL propagation to/from IP packets to be configured
Date: Mon, 13 Mar 2017 13:28:59 -0700	[thread overview]
Message-ID: <58C7010B.2010609@cumulusnetworks.com> (raw)
In-Reply-To: <1489178605-30027-1-git-send-email-rshearma@brocade.com>

On 3/10/17, 12:43 PM, Robert Shearman wrote:
> It is sometimes desirable to present an MPLS transport network as a
> single hop to traffic transiting it because it prevents confusion when
> diagnosing failures. An example of where confusion can be generated is
> when addresses used in the provider network overlap with addresses in
> the overlay network and the addresses get exposed through ICMP errors
> generated as packets transit the provider network.
>
> In addition, RFC 3443 defines two methods of deriving TTL for an
> outgoing packet: Uniform Model where the TTL is propagated to/from the
> MPLS header and both Pipe Models and Short Pipe Models (with and
> without PHP) where the TTL is not propagated to/from the MPLS header.
>
> Changes in v3:
>  - decrement ttl on popping last label when not doing ttl propagation,
>    as suggested by David Ahern.
>  - add comment to describe what the somewhat complex conditionals are
>    doing to work out what ttl to use in mpls_iptunnel.c.
>  - rearrange fields fields in struct netns_mpls to keep the platform
>    label fields together, as suggested by David Ahern.
>
> Changes in v2:
>  - add references to RFC 3443 as suggested by David Ahern
>  - fix setting of skb->protocol as noticed by David Ahern
>  - implement per-route/per-LWT configurability as suggested by Eric
>    Biederman
>  - split into two patches for ease of review
>
> Robert Shearman (2):
>   mpls: allow TTL propagation to IP packets to be configured
>   mpls: allow TTL propagation from IP packets to be configured
>
>  
Acked-by: Roopa Prabhu <roopa@cumulusnetworks•com>

  parent reply	other threads:[~2017-03-13 20:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-30 20:36 [PATCH net-next] mpls: allow TTL propagation to/from IP packets to be configured Robert Shearman
2017-01-31  0:17 ` Eric W. Biederman
2017-01-31 11:59   ` Robert Shearman
2017-02-03  3:21     ` Eric W. Biederman
2017-02-03  4:02       ` David Ahern
2017-01-31  0:41 ` David Ahern
2017-01-31 12:00   ` Robert Shearman
2017-01-31  1:09 ` David Ahern
2017-01-31 12:01   ` Robert Shearman
2017-03-08  0:46 ` [PATCH net-next v2 0/2] " Robert Shearman
2017-03-08  0:46   ` [PATCH net-next v2 1/2] mpls: allow TTL propagation to " Robert Shearman
2017-03-10  2:00     ` David Ahern
2017-03-10 10:12       ` Robert Shearman
2017-03-10  2:40     ` David Ahern
2017-03-10 10:12       ` Robert Shearman
2017-03-08  0:46   ` [PATCH net-next v2 2/2] mpls: allow TTL propagation from " Robert Shearman
2017-03-10  2:54     ` David Ahern
2017-03-10 10:12       ` Robert Shearman
2017-03-10 20:43   ` [PATCH net-next v3 0/2] mpls: allow TTL propagation to/from " Robert Shearman
2017-03-10 20:43     ` [PATCH net-next v3 1/2] mpls: allow TTL propagation to " Robert Shearman
2017-03-13 18:42       ` David Ahern
2017-03-10 20:43     ` [PATCH net-next v3 2/2] mpls: allow TTL propagation from " Robert Shearman
2017-03-13 18:43       ` David Ahern
2017-03-13 20:28     ` Roopa Prabhu [this message]
2017-03-13 22:29     ` [PATCH net-next v3 0/2] mpls: allow TTL propagation to/from " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58C7010B.2010609@cumulusnetworks.com \
    --to=roopa@cumulusnetworks$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=dsa@cumulusnetworks$(echo .)com \
    --cc=ebiederm@xmission$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=rshearma@brocade$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox