From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: David Ahern <dsa@cumulusnetworks•com>
Cc: netdev@vger•kernel.org, vyasevic@redhat•com, davem@davemloft•net
Subject: Re: [PATCH net-next 1/8] rtnetlink: Do not generate notifications for MTU events
Date: Sat, 08 Apr 2017 11:06:17 -0700 [thread overview]
Message-ID: <58E92699.6090909@cumulusnetworks.com> (raw)
In-Reply-To: <1491600340-8359-2-git-send-email-dsa@cumulusnetworks.com>
On 4/7/17, 2:25 PM, David Ahern wrote:
> Changing MTU on a link currently causes 3 messages to be sent to userspace:
>
> [LINK]11: dummy1: <BROADCAST,NOARP,UP,LOWER_UP> mtu 1490 qdisc noqueue state UNKNOWN group default event PRE_CHANGE_MTU
> link/ether f2:52:5c:6d:21:f3 brd ff:ff:ff:ff:ff:ff
>
> [LINK]11: dummy1: <BROADCAST,NOARP,UP,LOWER_UP> mtu 1500 qdisc noqueue state UNKNOWN group default event CHANGE_MTU
> link/ether f2:52:5c:6d:21:f3 brd ff:ff:ff:ff:ff:ff
>
> [LINK]11: dummy1: <BROADCAST,NOARP,UP,LOWER_UP> mtu 1500 qdisc noqueue state UNKNOWN group default
> link/ether f2:52:5c:6d:21:f3 brd ff:ff:ff:ff:ff:ff
>
> Remove the PRE_CHANGE_MTU and CHANGE_MTU messages.
>
>
This change is good... multiple notifications for the same event does not help in large scale links setups. However, this
reverts what vlad was trying to do with his patchset. Vlad's patch-set relies on the rtnl notifications generated from
notifiers (rtnetlink_event) to add specific event (IFLA_EVENT) in notifications.
The third notification in your example above is the correct one and is an aggregate notification for a set of changes, but
it cannot really fill in all types of events in the single IFLA_EVENT attribute as it stands today. IFLA_EVENT should be
a bitmask to include all events in this case (i had indicated this in vlads first version).
next prev parent reply other threads:[~2017-04-08 18:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 21:25 [PATCH net-next 0/8] rtnetlink: Cleanup user notifications for netdev events David Ahern
2017-04-07 21:25 ` [PATCH net-next 1/8] rtnetlink: Do not generate notifications for MTU events David Ahern
2017-04-08 18:06 ` Roopa Prabhu [this message]
2017-04-08 18:13 ` David Ahern
2017-04-08 18:18 ` Roopa Prabhu
2017-04-10 15:39 ` Vlad Yasevich
2017-04-10 15:49 ` David Ahern
2017-04-15 1:51 ` Vlad Yasevich
2017-04-15 4:26 ` David Ahern
2017-04-18 7:52 ` Nicolas Dichtel
2017-04-09 1:36 ` Vlad Yasevich
2017-04-09 2:58 ` David Ahern
2017-04-07 21:25 ` [PATCH net-next 2/8] rtnetlink: Do not generate notification for UDP_TUNNEL_PUSH_INFO David Ahern
2017-04-07 21:25 ` [PATCH net-next 3/8] rtnetlink: Do not generate notifications for CHANGEADDR event David Ahern
2017-04-07 21:25 ` [PATCH net-next 4/8] rtnetlink: Do not generate notifications for POST_TYPE_CHANGE event David Ahern
2017-04-07 21:25 ` [PATCH net-next 5/8] rtnetlink: Remove NETDEV_CHANGEINFODATA netdev event David Ahern
2017-04-07 21:25 ` [PATCH net-next 6/8] rtnetlink: Do not generate notifications for PRECHANGEUPPER event David Ahern
2017-04-07 21:25 ` [PATCH net-next 7/8] rtnetlink: Do not generate notifications for NOTIFY_PEERS event David Ahern
2017-04-09 1:37 ` Vlad Yasevich
2017-04-07 21:25 ` [PATCH net-next 8/8] rtnetlink: Do not generate notifications for CHANGELOWERSTATE event David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58E92699.6090909@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsa@cumulusnetworks$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vyasevic@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox