From: Daniel Borkmann <daniel@iogearbox•net>
To: Jamal Hadi Salim <jhs@mojatatu•com>,
Stephen Hemminger <stephen@networkplumber•org>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: compile issue in latest iproute2
Date: Sat, 22 Apr 2017 18:18:58 +0200 [thread overview]
Message-ID: <58FB8272.5080306@iogearbox.net> (raw)
In-Reply-To: <58FB7012.4080907@iogearbox.net>
On 04/22/2017 05:00 PM, Daniel Borkmann wrote:
> On 04/22/2017 02:31 PM, Jamal Hadi Salim wrote:
>>
>> I dont think is a kernel uapi - but it was failing compiling
>> when HAVE_ELF is false.
>> -----
>> jhs@jhs-UX:~/git-trees/others/iproute-with-ck$ git diff include/bpf_util.h
>> diff --git a/include/bpf_util.h b/include/bpf_util.h
>> index 5361dab..edca339 100644
>> --- a/include/bpf_util.h
>> +++ b/include/bpf_util.h
>> @@ -266,7 +266,7 @@ int bpf_send_map_fds(const char *path, const char *obj);
>> int bpf_recv_map_fds(const char *path, int *fds, struct bpf_map_aux *aux,
>> unsigned int entries);
>> #else
>> -static inline int bpf_send_map_fds(const char *path, const char *obj)
>> +inline int bpf_send_map_fds(const char *path, const char *obj)
>> {
>> return 0;
>> }
>> -----
>>
>> Let me know if you want a formal patch or feel free to take it.
>
> Will resolve it and send a patch later today, thanks!
Hmm, I'm on latest f443565f8df6 ("ip vrf: Add command name next to
pid") commit in master branch. Compiles fine for me with and without
ELF support. I verified that there's no HAVE_ELF defined and I'm
not seeing an error.
Without ELF support:
# ./configure
TC schedulers
ATM no
libc has setns: yes
SELinux support: yes
ELF support: no
libmnl support: yes
Berkeley DB: yes
docs: latex: yes
pdflatex: yes
sgml2latex: no
WARNING: no LaTeX files can be build from SGML files
sgml2html: no
WARNING: no HTML docs can be built from SGML
# make > /dev/null
ssfilter.y: conflicts: 35 shift/reduce
#
With ELF support:
# ./configure
TC schedulers
ATM no
libc has setns: yes
SELinux support: yes
ELF support: yes
libmnl support: yes
Berkeley DB: yes
docs: latex: yes
pdflatex: yes
sgml2latex: no
WARNING: no LaTeX files can be build from SGML files
sgml2html: no
WARNING: no HTML docs can be built from SGML
# make > /dev/null
ssfilter.y: conflicts: 35 shift/reduce
#
Anything I'm missing?
next prev parent reply other threads:[~2017-04-22 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-22 12:31 compile issue in latest iproute2 Jamal Hadi Salim
2017-04-22 15:00 ` Daniel Borkmann
2017-04-22 16:18 ` Daniel Borkmann [this message]
2017-04-22 16:43 ` Jamal Hadi Salim
2017-04-22 16:54 ` Stephen Hemminger
2017-04-22 20:06 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58FB8272.5080306@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=jhs@mojatatu$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox