From: Daniel Borkmann <daniel@iogearbox•net>
To: Jakub Kicinski <jakub.kicinski@netronome•com>, netdev@vger•kernel.org
Cc: davem@davemloft•net, johannes@sipsolutions•net,
dsa@cumulusnetworks•com, alexei.starovoitov@gmail•com,
bblanco@gmail•com, john.fastabend@gmail•com, kubakici@wp•pl,
oss-drivers@netronome•com
Subject: Re: [RFC 0/4] xdp: use netlink extended ACK reporting
Date: Tue, 25 Apr 2017 11:05:27 +0200 [thread overview]
Message-ID: <58FF1157.8030309@iogearbox.net> (raw)
In-Reply-To: <20170425080644.122536-1-jakub.kicinski@netronome.com>
On 04/25/2017 10:06 AM, Jakub Kicinski wrote:
> Hi!
>
> This series is an attempt to make XDP more user friendly by
> enabling exploiting the recently added netlink extended ACK
> reporting to carry messages to user space.
>
> I made iproute2 parse the extended messages and have it showing
> the errors like this:
>
> # ip link set dev p4p1 xdp obj ipip_prepend.o sec ".text"
> RTNETLINK answers: Invalid argument (MTU too large w/ XDP enabled)
>
> Where the message is coming directly from the driver. There could
> still be a bit of a leap for a complete novice from the message
> above to the right settings. I wonder if it would be worthwhile
But still 100x better than the current situation. ;) I really
like the series, thanks for working on this!
> adding #defines for the most common configuration conflicts?
> Sharing the messages verbatim between drivers could make them easier
> to google.
Makes sense, once more drivers adapt to this reporting, these
messages could be consolidated.
> Also - is anyone working on adding proper extack support to iproute2?
> The code I have right now is a bit of a hack...
>
> Jakub Kicinski (4):
> netlink: make extended ACK setting NULL-friendly
> xdp: propagate extended ack to XDP setup
> nfp: make use of extended ack message reporting
> virtio_net: make use of extended ack message reporting
>
> drivers/net/ethernet/netronome/nfp/nfp_net.h | 3 ++-
> .../net/ethernet/netronome/nfp/nfp_net_common.c | 22 +++++++++++++---------
> .../net/ethernet/netronome/nfp/nfp_net_ethtool.c | 4 ++--
> drivers/net/virtio_net.c | 11 +++++++----
> include/linux/netdevice.h | 10 ++++++++--
> include/linux/netlink.h | 12 ++++++++----
> net/core/dev.c | 5 ++++-
> net/core/rtnetlink.c | 13 ++++++++-----
> 8 files changed, 52 insertions(+), 28 deletions(-)
>
next prev parent reply other threads:[~2017-04-25 9:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 8:06 [RFC 0/4] xdp: use netlink extended ACK reporting Jakub Kicinski
2017-04-25 8:06 ` [RFC 1/4] netlink: make extended ACK setting NULL-friendly Jakub Kicinski
2017-04-25 8:13 ` Johannes Berg
2017-04-25 20:53 ` Jakub Kicinski
2017-04-26 7:17 ` Johannes Berg
2017-04-25 9:12 ` Daniel Borkmann
2017-04-25 8:06 ` [RFC 2/4] xdp: propagate extended ack to XDP setup Jakub Kicinski
2017-04-25 8:06 ` [RFC 3/4] nfp: make use of extended ack message reporting Jakub Kicinski
2017-04-25 12:42 ` Jamal Hadi Salim
2017-04-25 14:20 ` David Miller
2017-04-26 11:13 ` [oss-drivers] " Simon Horman
2017-04-26 13:03 ` Jamal Hadi Salim
2017-04-26 13:31 ` Daniel Borkmann
2017-04-26 14:44 ` David Miller
2017-04-26 18:44 ` Simon Horman
2017-04-25 8:06 ` [RFC 4/4] virtio_net: " Jakub Kicinski
2017-04-25 9:05 ` Daniel Borkmann [this message]
2017-04-25 16:54 ` [RFC 0/4] xdp: use netlink extended ACK reporting Jesper Dangaard Brouer
2017-04-25 21:00 ` Jakub Kicinski
2017-04-25 14:53 ` David Ahern
2017-04-25 21:05 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58FF1157.8030309@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=bblanco@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsa@cumulusnetworks$(echo .)com \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kubakici@wp$(echo .)pl \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss-drivers@netronome$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox