public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox•net>
To: Jesper Dangaard Brouer <brouer@redhat•com>,
	dsa@cumulusnetworks•com, netdev@vger•kernel.org
Cc: Daniel Borkmann <borkmann@iogearbox•net>,
	Alexei Starovoitov <alexei.starovoitov@gmail•com>
Subject: Re: [net-next PATCH 1/2] samples/bpf: fix SKB_MODE flag to be a 32-bit unsigned int
Date: Mon, 01 May 2017 11:55:38 +0200	[thread overview]
Message-ID: <5907061A.9070409@iogearbox.net> (raw)
In-Reply-To: <149363077553.17600.5609466598508053296.stgit@firesoul>

On 05/01/2017 11:26 AM, Jesper Dangaard Brouer wrote:
> The kernel side of XDP_FLAGS_SKB_MODE is unsigned, and the rtnetlink
> IFLA_XDP_FLAGS is defined as NLA_U32. Thus, userspace programs under
> samples/bpf/ should use the correct type.
>
> Fixes: 3993f2cb983b ("samples/bpf: Add support for SKB_MODE to xdp1 and xdp_tx_iptunnel")
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat•com>

Acked-by: Daniel Borkmann <daniel@iogearbox•net>

  reply	other threads:[~2017-05-01  9:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27 16:11 [PATCH net-next] samples/bpf: Add support for SKB_MODE to xdp1 and xdp_tx_iptunnel David Ahern
2017-04-27 16:38 ` Alexei Starovoitov
2017-04-27 16:49   ` David Miller
2017-04-28 21:40 ` Jesper Dangaard Brouer
2017-04-30 23:46   ` David Ahern
2017-05-01  9:09     ` Jesper Dangaard Brouer
2017-05-01  9:26     ` [net-next PATCH 0/2] samples/bpf: two bug fixes to XDP_FLAGS_SKB_MODE attaching Jesper Dangaard Brouer
2017-05-01  9:26       ` [net-next PATCH 1/2] samples/bpf: fix SKB_MODE flag to be a 32-bit unsigned int Jesper Dangaard Brouer
2017-05-01  9:55         ` Daniel Borkmann [this message]
2017-05-01 13:27         ` Andy Gospodarek
2017-05-01  9:26       ` [net-next PATCH 2/2] samples/bpf: fix XDP_FLAGS_SKB_MODE detach for xdp_tx_iptunnel Jesper Dangaard Brouer
2017-05-01  9:56         ` Daniel Borkmann
2017-05-01 13:28         ` Andy Gospodarek
2017-05-01 14:42       ` [net-next PATCH 0/2] samples/bpf: two bug fixes to XDP_FLAGS_SKB_MODE attaching David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5907061A.9070409@iogearbox.net \
    --to=daniel@iogearbox$(echo .)net \
    --cc=alexei.starovoitov@gmail$(echo .)com \
    --cc=borkmann@iogearbox$(echo .)net \
    --cc=brouer@redhat$(echo .)com \
    --cc=dsa@cumulusnetworks$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox