From: Daniel Borkmann <daniel@iogearbox•net>
To: David Miller <davem@davemloft•net>, ast@fb•com
Cc: netdev@vger•kernel.org
Subject: Re: bpf pointer alignment validation
Date: Mon, 08 May 2017 12:49:25 +0200 [thread overview]
Message-ID: <59104D35.8080108@iogearbox.net> (raw)
In-Reply-To: <20170505.224709.1156323937148435706.davem@davemloft.net>
On 05/06/2017 04:47 AM, David Miller wrote:
> From: David Miller <davem@davemloft•net>
> Date: Fri, 05 May 2017 16:20:44 -0400 (EDT)
>
>> Anyways, I'll play with this design and see what happens...
>> Feedback is of course welcome.
>
> Here is a prototype that works for me with test_pkt_access.c,
> which otherwise won't load on sparc.
Code looks good to me as far as I can tell, thanks for working
on this.
Could you also add test cases specifically to this for test_verifier
in bpf selftests? I'm thinking of the cases when we have no pkt id
and offset originated from reg->off (accumulated through const imm
ops on reg) and insn->off, where we had i) no pkt id and ii) a
specific pkt id (so we can probe for aux_off_align rejection as well).
I believe we do have coverage to some extend in some of the tests
(more on the map_value_adj though), but it would be good to keep
tracking this specifically as well.
Thanks a lot,
Daniel
next prev parent reply other threads:[~2017-05-08 10:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 20:20 bpf pointer alignment validation David Miller
2017-05-06 2:47 ` David Miller
2017-05-08 10:49 ` Daniel Borkmann [this message]
2017-05-08 15:04 ` David Miller
2017-05-09 18:32 ` David Miller
2017-05-10 5:57 ` Alexei Starovoitov
2017-05-10 11:12 ` David Laight
2017-05-10 15:33 ` David Miller
2017-05-10 15:51 ` Daniel Borkmann
2017-05-10 15:57 ` David Miller
2017-05-10 16:15 ` Alexei Starovoitov
2017-05-10 16:21 ` Daniel Borkmann
2017-05-10 16:45 ` David Miller
2017-05-08 17:30 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59104D35.8080108@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=ast@fb$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox