From: Bhavesh Davda <bhavesh@vmware•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
pv-drivers@vmware•com, sbhatewara@vmware•com
Subject: Re: [PATCH net-next] vmxnet3: prevent div-by-zero panic when ring resizing uninitialized dev
Date: Wed, 6 Mar 2013 14:00:11 -0800 (PST) [thread overview]
Message-ID: <591552351.12774238.1362607211741.JavaMail.root@vmware.com> (raw)
In-Reply-To: <20130306.153841.784919874486534382.davem@davemloft.net>
> > ---
> > drivers/net/vmxnet3/vmxnet3_drv.c | 3 ++-
> > drivers/net/vmxnet3/vmxnet3_ethtool.c | 6 ++++++
> > drivers/net/vmxnet3/vmxnet3_int.h | 4 ++--
> > 3 files changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c
> > b/drivers/net/vmxnet3/vmxnet3_drv.c
> > index 4aad350..bfc5898 100644
> > --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> > +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> > @@ -2922,7 +2922,7 @@ vmxnet3_probe_device(struct pci_dev *pdev,
> > (int)num_online_cpus());
> > else
> > #endif
> > - num_rx_queues = 1;
> > + num_rx_queues = 1;
>
> Why are you un-indenting this else branch? Please don't do that
>
Just to annoy you :) [Sorry, couldn't resist.]
I'm sorry I didn't notice I was breaking the indent of the else branch. For some reason checkpatch didn't complain.
While at it, I'm also changing the netdev_info to netdev_err in vmxnet3_ethtool.c.
You didn't explicitly ask for it, so I wasn't sure if I should repost the patch. I'm going to repost it any way and leave it up to you on which patch you want to apply.
Thanks.
- Bhavesh
next prev parent reply other threads:[~2013-03-06 22:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 17:46 [PATCH net-next] vmxnet3: prevent div-by-zero panic when ring resizing uninitialized dev Bhavesh Davda
2013-03-06 20:38 ` David Miller
2013-03-06 22:00 ` Bhavesh Davda [this message]
2013-03-06 22:04 ` Bhavesh Davda
2013-03-06 22:09 ` David Miller
2013-03-07 21:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=591552351.12774238.1362607211741.JavaMail.root@vmware.com \
--to=bhavesh@vmware$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pv-drivers@vmware$(echo .)com \
--cc=sbhatewara@vmware$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox