From: Daniel Borkmann <daniel@iogearbox•net>
To: David Lebrun <david.lebrun@uclouvain•be>,
David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net v2] ipv6: sr: fix user space compilation error with old glibc
Date: Tue, 23 May 2017 19:27:07 +0200 [thread overview]
Message-ID: <592470EB.5090701@iogearbox.net> (raw)
In-Reply-To: <9f06720b-1a6e-2a0b-0756-70e9e73b631f@uclouvain.be>
On 05/15/2017 04:21 PM, David Lebrun wrote:
> On 05/15/2017 04:09 PM, David Miller wrote:
>> Please, no.
>>
>> The reason we put together a method by which glibc and the kernel can
>> stay out of eachother's way in header files is exactly so that we
>> don't need ifdefs that conditionally do netinet/in.h vs. using the
>> kernel header.
>>
>> There are more than a dozen other UAPI headers which make use of
>> linux/in6.h and none of them jump through hoops like what is being
>> proposed here, and that's on purpose.
>>
>> So special casing this one one header is really not the way to go.
>
> Mmmh it's true that special casing in kernel headers for a user space
> issue is not the best way to go.. I'll find a way to solve this in user
> space only.
>
> Sorry about the lousy patch.
Any new outcomes so far?
Thanks,
Daniel
prev parent reply other threads:[~2017-05-23 17:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 11:03 [PATCH net v2] ipv6: sr: fix user space compilation error with old glibc David Lebrun
2017-05-15 14:09 ` David Miller
2017-05-15 14:21 ` David Lebrun
2017-05-23 17:27 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=592470EB.5090701@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=david.lebrun@uclouvain$(echo .)be \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox