From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: Mark Bloch <markb@mellanox•com>
Cc: jbenc@redhat•com, roid@mellanox•com, netdev@vger•kernel.org
Subject: Re: [net,V2] vxlan: fix use-after-free on deletion
Date: Thu, 01 Jun 2017 20:31:12 -0700 [thread overview]
Message-ID: <5930DC00.5090201@cumulusnetworks.com> (raw)
In-Reply-To: <1496363048-21138-1-git-send-email-markb@mellanox.com>
On 6/1/17, 5:24 PM, Mark Bloch wrote:
> Adding a vxlan interface to a socket isn't symmetrical, while adding
> is done in vxlan_open() the deletion is done in vxlan_dellink().
> This can cause a use-after-free error when we close the vxlan
> interface before deleting it.
>
> We add vxlan_vs_del_dev() to match vxlan_vs_add_dev() and call
> it from vxlan_stop() to match the call from vxlan_open().
>
> Fixes: 56ef9c909b40 ("vxlan: Move socket initialization to within rtnl scope")
> Acked-by: Jiri Benc <jbenc@redhat•com>
> Tested-by: Roi Dayan <roid@mellanox•com>
> Signed-off-by: Mark Bloch <markb@mellanox•com>
Acked-by: Roopa Prabhu <roopa@cumulusnetworks•com>
next prev parent reply other threads:[~2017-06-02 3:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 0:24 [net,V2] vxlan: fix use-after-free on deletion Mark Bloch
2017-06-02 3:31 ` Roopa Prabhu [this message]
2017-06-02 18:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5930DC00.5090201@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=jbenc@redhat$(echo .)com \
--cc=markb@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roid@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox