From: Daniel Borkmann <daniel@iogearbox•net>
To: Stephen Hemminger <stephen@networkplumber•org>
Cc: ast@fb•com, netdev@vger•kernel.org
Subject: Re: [PATCH iproute2 master 1/2] bpf: improve error reporting around tail calls
Date: Sat, 22 Jul 2017 10:06:37 +0200 [thread overview]
Message-ID: <5973078D.4080905@iogearbox.net> (raw)
In-Reply-To: <20170721162825.0b42e9ba@xeon-e3>
On 07/22/2017 01:28 AM, Stephen Hemminger wrote:
> On Fri, 21 Jul 2017 21:13:06 +0200
> Daniel Borkmann <daniel@iogearbox•net> wrote:
>
>> Currently, it's still quite hard to figure out if a prog passed the
>> verifier, but later gets rejected due to different tail call ownership.
>> Figure out whether that is the case and provide appropriate error
>> messages to the user.
>>
>> Signed-off-by: Daniel Borkmann <daniel@iogearbox•net>
>
> Sorry, dead code. Please fix and resubmit.
>
> bpf.c:356:12: warning: ‘bpf_derive_prog_from_fdinfo’ defined but not used [-Wunused-function]
> static int bpf_derive_prog_from_fdinfo(int fd, struct bpf_prog_data *prog)
Yeah, v2 coming later today. I didn't compile with !HAVE_ELF,
where it's not in use indeed. Thanks!
next prev parent reply other threads:[~2017-07-22 8:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 19:13 [PATCH iproute2 master 0/2] Minor BPF updates Daniel Borkmann
2017-07-21 19:13 ` [PATCH iproute2 master 1/2] bpf: improve error reporting around tail calls Daniel Borkmann
2017-07-21 23:28 ` Stephen Hemminger
2017-07-22 8:06 ` Daniel Borkmann [this message]
2017-07-21 19:13 ` [PATCH iproute2 master 2/2] bpf: fix mnt path when from env Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5973078D.4080905@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=ast@fb$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox