From: John Fastabend <john.fastabend@gmail•com>
To: Alexei Starovoitov <ast@fb•com>, Martin KaFai Lau <kafai@fb•com>,
netdev@vger•kernel.org
Cc: Daniel Borkmann <daniel@iogearbox•net>, kernel-team@fb•com
Subject: Re: [PATCH net-next] bpf: Fix map-in-map checking in the verifier
Date: Thu, 17 Aug 2017 19:08:26 -0700 [thread overview]
Message-ID: <59964C1A.7050902@gmail.com> (raw)
In-Reply-To: <eb62aeba-487b-e3fe-3c9d-85c0b8eeaf04@fb.com>
On 08/17/2017 06:17 PM, Alexei Starovoitov wrote:
> On 8/17/17 6:14 PM, Martin KaFai Lau wrote:
>> In check_map_func_compatibility(), a 'break' has been accidentally
>> removed for the BPF_MAP_TYPE_ARRAY_OF_MAPS and BPF_MAP_TYPE_HASH_OF_MAPS
>> cases. This patch adds it back.
>>
>> Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support")
>> Cc: John Fastabend <john.fastabend@gmail•com>
>> Signed-off-by: Martin KaFai Lau <kafai@fb•com>
>
> Nice catch!
> Acked-by: Alexei Starovoitov <ast@kernel•org>
>
Thanks a lot!
Acked-by: John Fastabend <john.fastabend@gmail•com>
next prev parent reply other threads:[~2017-08-18 2:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 1:14 [PATCH net-next] bpf: Fix map-in-map checking in the verifier Martin KaFai Lau
2017-08-18 1:17 ` Alexei Starovoitov
2017-08-18 2:08 ` John Fastabend [this message]
2017-08-18 8:10 ` Daniel Borkmann
2017-08-18 23:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59964C1A.7050902@gmail.com \
--to=john.fastabend@gmail$(echo .)com \
--cc=ast@fb$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=kafai@fb$(echo .)com \
--cc=kernel-team@fb$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox