Subject: Re: [PATCH net-next] bpf: netdev is never null in __dev_map_flush

From: John Fastabend <[email-masked]>
Date: Wed, 23 Aug 2017 20:10:15 -0700

On 08/23/2017 06:25 PM, Alexei Starovoitov wrote:
> On 8/23/17 6:20 PM, Daniel Borkmann wrote:
>> No need to test for it in fast-path, every dev in bpf_dtab_netdev
>> is guaranteed to be non-NULL, otherwise dev_map_update_elem() will
>> fail in the first place.
>>
>> Signed-off-by: Daniel Borkmann <[email-masked]>
> 
> wow. interesting. I'm surprised you see a difference from
> such micro-optimization.
> Acked-by: Alexei Starovoitov <[email-masked]>
> 
> 

Thanks for the clean up, I was a bit over paranoid here as well. Is
this actually noticeable in pps benchmark or just making the code
cleaner? Just curious.

Acked-by: John Fastabend <[email-masked]>