From: Daniel Borkmann <daniel@iogearbox•net>
To: Jakub Kicinski <jakub.kicinski@netronome•com>, netdev@vger•kernel.org
Cc: oss-drivers@netronome•com, alexei.starovoitov@gmail•com,
Lawrence Brakmo <brakmo@fb•com>
Subject: Re: [PATCH net-next] net: filter: remove unused variable and fix warning
Date: Mon, 30 Oct 2017 22:55:14 +0100 [thread overview]
Message-ID: <59F79FC2.6010402@iogearbox.net> (raw)
In-Reply-To: <20171030204647.854-1-jakub.kicinski@netronome.com>
On 10/30/2017 09:46 PM, Jakub Kicinski wrote:
> bpf_getsockopt bpf call sets the ret variable to zero and
> never changes it. What's worse in case CONFIG_INET is
> not selected the variable is completely unused generating
> a warning.
>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome•com>
> Reviewed-by: Quentin Monnet <quentin.monnet@netronome•com>
Acked-by: Daniel Borkmann <daniel@iogearbox•net>
next prev parent reply other threads:[~2017-10-30 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 20:46 [PATCH net-next] net: filter: remove unused variable and fix warning Jakub Kicinski
2017-10-30 21:13 ` Lawrence Brakmo
2017-10-30 21:55 ` Daniel Borkmann [this message]
2017-10-30 21:56 ` Alexei Starovoitov
2017-10-31 0:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59F79FC2.6010402@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=brakmo@fb$(echo .)com \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss-drivers@netronome$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox