From: Arend van Spriel <arend.vanspriel@broadcom•com>
To: Andrew Lunn <andrew@lunn•ch>
Cc: "open list:NETWORKING DRIVERS" <netdev@vger•kernel.org>,
Vivien Didelot <vivien.didelot@savoirfairelinux•com>,
Arnd Bergmann <arnd@arndb•de>
Subject: Re: [PATCH] dsa: dsa2: fix compile error for !CONFIG_OF
Date: Fri, 24 Nov 2017 10:34:41 +0100 [thread overview]
Message-ID: <5A17E7B1.8000609@broadcom.com> (raw)
In-Reply-To: <20171124022826.GA32569@lunn.ch>
On 11/24/2017 3:28 AM, Andrew Lunn wrote:
> On Thu, Nov 23, 2017 at 08:27:48PM +0100, Arend Van Spriel wrote:
>> + Arnd
>>
>> On Thu, Nov 23, 2017 at 8:12 PM, Arend Van Spriel
>> <arend.vanspriel@broadcom•com> wrote:
>>> On Thu, Nov 23, 2017 at 3:04 PM, Andrew Lunn <andrew@lunn•ch> wrote:
>>>> On Thu, Nov 23, 2017 at 01:00:51PM +0100, Arend van Spriel wrote:
>>>>> Compilation fails building on x86_64 platform which does not
>>>>> have CONFIG_OF enabled.
>>>>>
>>>>> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom•com>
>>>>> ---
>>>>> After rebasing my branch to v4.14 I attempted to build the kernel and hit
>>>>> the following compile issue:
>>>>>
>>>>> net/dsa/dsa2.c: In function \u2018dsa_switch_parse_member_of\u2019:
>>>>> net/dsa/dsa2.c:678:2: error: implicit declaration of function
>>>>> 'of_property_read_variable_u32_array'
>>>>
>>>> Hi Arend
>>>>
>>>> https://lkml.org/lkml/2017/11/6/493
>>>
>>> So my email/patch did get through initially. Sorry for the noise and
>>> thanks for the info.
>>
>> Hi Andrew,
>>
>> Getting back to this. It seems that this patch did not get in. At
>> least I searched for it in v4.14.1 but no luck.
>
> Hi Arned
>
> The use of of_property_read_variable_u32_array was added in
> 975e6e32215e ("net: dsa: rework switch parsing"). This patch is not in
> v4.14. It is in linus/master, so v4.15-rc1 should have it. And the fix
> is also in linus/master.
>
> So there does not appear to be anything wrong. I just built v4.14.1
> for x86_64 with DSA without problems.
Thanks, Andrew
I am actually using wireless-testing tree which it based on 4.14 and
throws in net-next and the wireless trees. I assume the fix did not go
through net-next. Sorry for the confusion.
Regards,
Arend
next prev parent reply other threads:[~2017-11-24 9:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 12:00 [PATCH] dsa: dsa2: fix compile error for !CONFIG_OF Arend van Spriel
2017-11-23 14:04 ` Andrew Lunn
2017-11-23 19:12 ` Arend Van Spriel
2017-11-23 19:27 ` Arend Van Spriel
2017-11-24 2:28 ` Andrew Lunn
2017-11-24 9:34 ` Arend van Spriel [this message]
2017-11-23 19:00 ` [RESEND PATCH] " Arend van Spriel
2017-11-25 14:54 ` [PATCH] " David Miller
2017-11-25 23:47 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A17E7B1.8000609@broadcom.com \
--to=arend.vanspriel@broadcom$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=arnd@arndb$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox