From: Arend van Spriel <arend.vanspriel-dY08KVG/lbpWk0Htik3J/w@public•gmane.org>
To: "Kalle Valo" <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public•gmane.org>,
"Rafał Miłecki" <rafal-g1n6cQUeyibVItvQsEIGlw@public•gmane.org>
Cc: "Rafał Miłecki" <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
"Franky Lin" <franky.lin-dY08KVG/lbpWk0Htik3J/w@public•gmane.org>,
"Hante Meuleman"
<hante.meuleman-dY08KVG/lbpWk0Htik3J/w@public•gmane.org>,
"Chi-Hsien Lin"
<chi-hsien.lin-+wT8y+m8/X5BDgjK7y7TUQ@public•gmane.org>,
"Wright Feng"
<wright.feng-+wT8y+m8/X5BDgjK7y7TUQ@public•gmane.org>,
"Pieter-Paul Giesberts"
<pieter-paul.giesberts-dY08KVG/lbpWk0Htik3J/w@public•gmane.org>,
"James Hughes"
<james.hughes-FnsA7b+Nu9XbIbC87yuRow@public•gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
brcm80211-dev-list.pdl-dY08KVG/lbpWk0Htik3J/w@public•gmane.org,
brcm80211-dev-list-+wT8y+m8/X5BDgjK7y7TUQ@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
"Linus Lüssing"
<linus.luessing-djzkFPsfvsizQB+pC5nmwQ@public•gmane.org>,
"Felix Fietkau" <nbd-Vt+b4OUoWG0@public•gmane.org>,
bridge-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public•gmane.org
Subject: Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default
Date: Wed, 14 Mar 2018 21:55:23 +0100 [thread overview]
Message-ID: <5AA98C3B.2070406@broadcom.com> (raw)
In-Reply-To: <877eqe63kr.fsf-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On 3/14/2018 5:10 PM, Kalle Valo wrote:
> Rafał Miłecki <rafal-g1n6cQUeyibVItvQsEIGlw@public•gmane.org> writes:
>
>>>> + unsigned char *eth_data = skb_mac_header(skb) + ETH_HLEN;
>>>> +#if !defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS)
>>>
>>> #ifndef?
>>
>> I followed what is used in the include/linux/etherdevice.h. Is that a
>> good exceuse? Could it be there any some good reason for #if defined()?
>
> Don't know, maybe just a matter of taste? But it would be nice to know
> the background behind #ifdef vs #if defined(), never figured it out why
> two different forms.
Well. In this case you could use either one, but if you have more
conditions #if defined() is bit more efficient:
#ifdef A
#ifdef B
#endif
#endif
vs.
#if defined(A) && defined(B)
Regards,
Arend
next prev parent reply other threads:[~2018-03-14 20:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 11:01 [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default Rafał Miłecki
[not found] ` <20180314110119.13631-1-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-03-14 12:58 ` Arend van Spriel
[not found] ` <5AA91C67.90001-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2018-03-14 15:39 ` Rafał Miłecki
[not found] ` <f145e568e9033db57a436ed3e2dad2c8-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
2018-03-14 15:40 ` Rafał Miłecki
2018-03-14 15:57 ` Rafał Miłecki
[not found] ` <ec7ef5fd9fb4193f92c0e0189cbe5e3e-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
2018-03-14 20:44 ` Arend van Spriel
2018-03-14 14:24 ` Kalle Valo
[not found] ` <878tau7n23.fsf-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-14 14:44 ` Arend van Spriel
[not found] ` <5AA93530.5040001-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2018-03-14 15:08 ` Kalle Valo
[not found] ` <87o9jq66f3.fsf-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-14 15:27 ` Stephen Hemminger
2018-03-14 15:28 ` Rafał Miłecki
2018-03-14 15:44 ` Rafał Miłecki
[not found] ` <52b1812dd3e843adb63ff67fbe95975f-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>
2018-03-14 16:10 ` Kalle Valo
[not found] ` <877eqe63kr.fsf-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-03-14 20:55 ` Arend van Spriel [this message]
[not found] ` <5AA98C3B.2070406-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2018-03-15 9:23 ` Kalle Valo
2018-03-14 15:08 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AA98C3B.2070406@broadcom.com \
--to=arend.vanspriel-dy08kvg/lbpwk0htik3j/w@public$(echo .)gmane.org \
--cc=brcm80211-dev-list-+wT8y+m8/X5BDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=brcm80211-dev-list.pdl-dY08KVG/lbpWk0Htik3J/w@public$(echo .)gmane.org \
--cc=bridge-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public$(echo .)gmane.org \
--cc=chi-hsien.lin-+wT8y+m8/X5BDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=franky.lin-dY08KVG/lbpWk0Htik3J/w@public$(echo .)gmane.org \
--cc=hante.meuleman-dY08KVG/lbpWk0Htik3J/w@public$(echo .)gmane.org \
--cc=james.hughes-FnsA7b+Nu9XbIbC87yuRow@public$(echo .)gmane.org \
--cc=kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public$(echo .)gmane.org \
--cc=linus.luessing-djzkFPsfvsizQB+pC5nmwQ@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=nbd-Vt+b4OUoWG0@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=pieter-paul.giesberts-dY08KVG/lbpWk0Htik3J/w@public$(echo .)gmane.org \
--cc=rafal-g1n6cQUeyibVItvQsEIGlw@public$(echo .)gmane.org \
--cc=wright.feng-+wT8y+m8/X5BDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=zajec5-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox