From: Arend van Spriel <arend.vanspriel-dY08KVG/lbpWk0Htik3J/w@public•gmane.org>
To: Lorenzo Bianconi
<lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org>
Cc: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public•gmane.org>,
kristian.evensen-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org,
linux-wireless
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCH] mt76: Enable NL80211_EXT_FEATURE_CQM_RSSI_LIST
Date: Mon, 13 Aug 2018 14:39:43 +0200 [thread overview]
Message-ID: <5B717C0F.5060302@broadcom.com> (raw)
In-Reply-To: <CAJ0CqmVZNAnHwnU4YqRRv7R8DyHi2MiFJr1bvQDPVszUU5Ez3g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 8/13/2018 12:55 PM, Lorenzo Bianconi wrote:
>> On 8/12/2018 8:14 PM, Kalle Valo wrote:
>>> Kristian Evensen <kristian.evensen-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org> writes:
>>>
>>>> Enable the use of CQM with mt76-devices.
>>>>
>>>> Signed-off-by: Kristian Evensen <kristian.evensen-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
>>>> ---
>>>> drivers/net/wireless/mediatek/mt76/mac80211.c | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/drivers/net/wireless/mediatek/mt76/mac80211.c b/drivers/net/wireless/mediatek/mt76/mac80211.c
>>>> index 029d54bc..3eb328ff 100644
>>>> --- a/drivers/net/wireless/mediatek/mt76/mac80211.c
>>>> +++ b/drivers/net/wireless/mediatek/mt76/mac80211.c
>>>> @@ -305,6 +305,8 @@ int mt76_register_device(struct mt76_dev *dev, bool vht,
>>>>
>>>> wiphy->features |= NL80211_FEATURE_ACTIVE_MONITOR;
>>>>
>>>> + wiphy_ext_feature_set(wiphy, NL80211_EXT_FEATURE_CQM_RSSI_LIST);
>>>
>>> So have you tested this and with what devices? For example, does it work
>>> with recently added USB devices?
>>
>> I was looking into this as it looks suspicious to me. From reading the
>> description of this ext_feature flag it seems this is an extention of CQM:
>>
>> """
>> * @NL80211_EXT_FEATURE_CQM_RSSI_LIST: With this driver the
>> * %NL80211_ATTR_CQM_RSSI_THOLD attribute accepts a list of zero or more
>> * RSSI threshold values to monitor rather than exactly one threshold.
>> """
>>
>> Also looking at mt76x2_bss_info_changed() it does not handle
>> BSS_CHANGED_CQM so I doubt it has support for it (yet). The driver does
>> not use IEEE80211_VIF_SUPPORTS_CQM_RSSI which is a requirement for it.
>>
>> Regards,
>> Arend
>>
>
> According to my understanding (please correct me if I am wrong)
> BSS_CHANGED_CQM is only needed if CQM_RSSI is handled
> by the driver/fw, while if it is not set mac80211 will take care of that
> in ieee80211_handle_beacon_sig routine.
Yeah. That explains it. Seems like mac80211 could actually set the
NL80211_EXT_FEATURE_CQM_RSSI_LIST flag is the driver does not set
IEEE80211_VIF_SUPPORTS_CQM_RSSI. That way all mac80211 drivers support
the list. Just a problem as the ext_feature is not a per-vif flag.
Regards,
Arend
next prev parent reply other threads:[~2018-08-13 12:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-12 14:52 [PATCH] mt76: Enable NL80211_EXT_FEATURE_CQM_RSSI_LIST Kristian Evensen
2018-08-12 18:14 ` Kalle Valo
[not found] ` <871sb3zc3v.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2018-08-12 18:44 ` Arend van Spriel
2018-08-13 4:58 ` Kristian Evensen
[not found] ` <5B708025.4090906-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2018-08-13 10:55 ` Lorenzo Bianconi
[not found] ` <CAJ0CqmVZNAnHwnU4YqRRv7R8DyHi2MiFJr1bvQDPVszUU5Ez3g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-08-13 12:39 ` Arend van Spriel [this message]
2018-08-13 14:25 ` Kristian Evensen
[not found] ` <CAKfDRXia3zwW9Q=7RZGqK_DWCsyQzG4KEZHsyHzGcNb70Ge1kA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-08-18 2:28 ` Andrew Zaborowski
2018-08-31 12:25 ` Kristian Evensen
2018-08-31 13:15 ` Lorenzo Bianconi
2018-08-31 13:20 ` Kristian Evensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B717C0F.5060302@broadcom.com \
--to=arend.vanspriel-dy08kvg/lbpwk0htik3j/w@public$(echo .)gmane.org \
--cc=kristian.evensen-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox