From: zhong jiang <zhongjiang@huawei•com>
To: <davem@davemloft•net>
Cc: <jhs@mojatatu•com>, <xiyou.wangcong@gmail•com>,
<jiri@resnulli•us>, <netdev@vger•kernel.org>,
<linux-kernel@vger•kernel.org>
Subject: Re: [PATCH] net: sched: Use FIELD_SIZEOF directly instead of reimplementing its function
Date: Wed, 19 Sep 2018 18:30:23 +0800 [thread overview]
Message-ID: <5BA2253F.4090409@huawei.com> (raw)
In-Reply-To: <1537351001-44480-1-git-send-email-zhongjiang@huawei.com>
On 2018/9/19 17:56, zhong jiang wrote:
> FIELD_SIZEOF is defined as a macro to calculate the specified vaule. Therefore,
> We prefer to use the macro rather than calculating its vaule.
s/vaule/value. will resend. sorry.
Thanks
zhong jiang
> Signed-off-by: zhong jiang <zhongjiang@huawei•com>
> ---
> net/sched/cls_flower.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
> index 4b8dd37..9aada2d 100644
> --- a/net/sched/cls_flower.c
> +++ b/net/sched/cls_flower.c
> @@ -993,7 +993,7 @@ static int fl_init_mask_hashtable(struct fl_flow_mask *mask)
> }
>
> #define FL_KEY_MEMBER_OFFSET(member) offsetof(struct fl_flow_key, member)
> -#define FL_KEY_MEMBER_SIZE(member) (sizeof(((struct fl_flow_key *) 0)->member))
> +#define FL_KEY_MEMBER_SIZE(member) FIELD_SIZEOF(struct fl_flow_key, member)
>
> #define FL_KEY_IS_MASKED(mask, member) \
> memchr_inv(((char *)mask) + FL_KEY_MEMBER_OFFSET(member), \
prev parent reply other threads:[~2018-09-19 10:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 9:56 [PATCH] net: sched: Use FIELD_SIZEOF directly instead of reimplementing its function zhong jiang
2018-09-19 10:30 ` zhong jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BA2253F.4090409@huawei.com \
--to=zhongjiang@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox