From: zhong jiang <zhongjiang@huawei•com>
To: <davem@davemloft•net>
Cc: <ubraun@linux•ibm.com>, <jwi@linux•ibm.com>,
<netdev@vger•kernel.org>, <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH] net: iucv: Use FIELD_SIZEOF directly instead of reimplementing its function
Date: Wed, 19 Sep 2018 18:31:13 +0800 [thread overview]
Message-ID: <5BA22571.1080101@huawei.com> (raw)
In-Reply-To: <1537350733-44276-1-git-send-email-zhongjiang@huawei.com>
On 2018/9/19 17:52, zhong jiang wrote:
> FIELD_SIZEOF is defined as a macro to calculate the specified vaule. Therefore,
> We prefer to use the macro rather than calculating its vaule.
s/vaule/value . will resend .
Thanks,
zhong jiang
> Signed-off-by: zhong jiang <zhongjiang@huawei•com>
> ---
> net/iucv/af_iucv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c
> index e2f16a0..5b68ee9 100644
> --- a/net/iucv/af_iucv.c
> +++ b/net/iucv/af_iucv.c
> @@ -48,7 +48,7 @@
> static const u8 iprm_shutdown[8] =
> {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01};
>
> -#define TRGCLS_SIZE (sizeof(((struct iucv_message *)0)->class))
> +#define TRGCLS_SIZE FIELD_SIZEOF(struct iucv_message, class)
>
> #define __iucv_sock_wait(sk, condition, timeo, ret) \
> do { \
prev parent reply other threads:[~2018-09-19 10:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 9:52 [PATCH] net: iucv: Use FIELD_SIZEOF directly instead of reimplementing its function zhong jiang
2018-09-19 10:31 ` zhong jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BA22571.1080101@huawei.com \
--to=zhongjiang@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jwi@linux$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ubraun@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox