From: "Samudrala, Sridhar" <sridhar.samudrala@intel•com>
To: Dan Carpenter <dan.carpenter@oracle•com>,
"David S. Miller" <davem@davemloft•net>
Cc: netdev@vger•kernel.org, kernel-janitors@vger•kernel.org,
Jiri Pirko <jiri@resnulli•us>,
Jay Vosburgh <j.vosburgh@gmail•com>
Subject: Re: [PATCH 1/2 net-next] net_failover: fix net_failover_compute_features()
Date: Thu, 31 May 2018 10:30:10 -0700 [thread overview]
Message-ID: <5a8a67ee-a21b-2153-67cc-ca588ca2b253@intel.com> (raw)
In-Reply-To: <20180531120124.pc4txiifxnrslbei@kili.mountain>
On 5/31/2018 5:01 AM, Dan Carpenter wrote:
> This has an '&' vs '|' typo so it starts with vlan_features set to none.
> Also a u32 type isn't large enough to hold all the feature bits, it
> should be netdev_features_t.
>
> Fixes: cfc80d9a1163 ("net: Introduce net_failover driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle•com>
The patch looks correct, but this code is based on team/bonding drivers.
So would like to get a confirmation from Jiri/Jay and if a similar fix is
needed in those drivers too.
>
> diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c
> index 8b508e2cf29b..ef50158e90a9 100644
> --- a/drivers/net/net_failover.c
> +++ b/drivers/net/net_failover.c
> @@ -380,7 +380,8 @@ static rx_handler_result_t net_failover_handle_frame(struct sk_buff **pskb)
>
> static void net_failover_compute_features(struct net_device *dev)
> {
> - u32 vlan_features = FAILOVER_VLAN_FEATURES & NETIF_F_ALL_FOR_ALL;
> + netdev_features_t vlan_features = FAILOVER_VLAN_FEATURES |
> + NETIF_F_ALL_FOR_ALL;
> netdev_features_t enc_features = FAILOVER_ENC_FEATURES;
> unsigned short max_hard_header_len = ETH_HLEN;
> unsigned int dst_release_flag = IFF_XMIT_DST_RELEASE |
next prev parent reply other threads:[~2018-05-31 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 12:01 [PATCH 1/2 net-next] net_failover: fix net_failover_compute_features() Dan Carpenter
2018-05-31 17:30 ` Samudrala, Sridhar [this message]
2018-06-04 13:31 ` David Miller
2018-06-04 14:43 ` [PATCH 1/2 v2 net-next] net_failover: Use netdev_features_t instead of u32 Dan Carpenter
2018-06-04 21:30 ` David Miller
2018-06-04 14:46 ` [PATCH 2/2 net] team: use " Dan Carpenter
2018-06-04 14:49 ` Jiri Pirko
2018-06-04 21:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a8a67ee-a21b-2153-67cc-ca588ca2b253@intel.com \
--to=sridhar.samudrala@intel$(echo .)com \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=j.vosburgh@gmail$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox