From: David Ahern <dsahern@gmail•com>
To: Saikrishna Arcot <sarcot@microsoft•com>,
Paul Menzel <pmenzel@molgen•mpg.de>,
Mike Manning <mmanning@vyatta•att-mail.com>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [EXTERNAL] Re: Change in behavior for bound vs unbound sockets
Date: Wed, 1 Sep 2021 20:41:57 -0700 [thread overview]
Message-ID: <5cada65e-9d75-ca9b-e0cc-0722ad71086d@gmail.com> (raw)
In-Reply-To: <BL0PR2101MB1316DCC9FFC2B0BBA9F66815D9CE9@BL0PR2101MB1316.namprd21.prod.outlook.com>
On 9/1/21 5:16 PM, Saikrishna Arcot wrote:
>
>> On 8/31/21 7:29 PM, Paul Menzel wrote:
>>>> Is the intention of those commits also meant to affect sockets that
>>>> are bound to just regular interfaces (and not only VRFs)? If so,
>>>> since this change breaks a userspace application, is it possible to
>>>> add a config that reverts to the old behavior, where bound sockets
>>>> are preferred over unbound sockets?
>>> If it breaks user space, the old behavior needs to be restored
>>> according to Linux' no regression policy. Let's hope, in the future,
>>> there is better testing infrastructure and such issues are noticed earlier.
>>
>> 5.0 was 2-1/2 years ago.
>
> Does that mean that this should be considered the new behavior? Is it
> possible to at least add a sysctl config to use the older behavior for
> non-VRF socket bindings?
>
>>
>> Feel free to add tests to tools/testing/selftests/net/fcnal-test.sh to cover any
>> missing permutations, including what you believe is the problem here. Both IPv4
>> and IPv6 should be added for consistency across protocols.
>>
>> nettest.c has a lot of the networking APIs, supports udp, tcp, raw, ...
>
> Let me try to add a test case there. I'm guessing test cases added there
> should pass with the current version of the kernel (i.e. should reflect the
> current behavior)?
>
Let's start by seeing test cases that demonstrate the problem.
prev parent reply other threads:[~2021-09-02 3:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 23:47 Change in behavior for bound vs unbound sockets Saikrishna Arcot
2021-08-31 10:12 ` Paul Menzel
2021-09-01 2:29 ` David Ahern
2021-09-02 0:16 ` [EXTERNAL] " Saikrishna Arcot
2021-09-02 3:41 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cada65e-9d75-ca9b-e0cc-0722ad71086d@gmail.com \
--to=dsahern@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=mmanning@vyatta$(echo .)att-mail.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pmenzel@molgen$(echo .)mpg.de \
--cc=sarcot@microsoft$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox