Subject: RE: [patch] be2net: signedness bug in be_msix_enable()

From: Sathya Perla <[email-masked]>
Date: Thu, 30 Jun 2016 16:52:56 +0530

> -----Original Message-----
> From: Dan Carpenter [mailto:[email-masked]]
>
> "num_vec" needs to be signed for the error handling to work.
>
> Fixes: e261768e9e39 ('be2net: support asymmetric rx/tx queue counts')
> Signed-off-by: Dan Carpenter <[email-masked]>
>
> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/drivers/net/ethernet/emulex/benet/be_main.c
> index 1873c74..1f16e73 100644
> --- a/drivers/net/ethernet/emulex/benet/be_main.c
> +++ b/drivers/net/ethernet/emulex/benet/be_main.c
> @@ -3251,8 +3251,9 @@ static void be_msix_disable(struct be_adapter
*adapter)
>
>  static int be_msix_enable(struct be_adapter *adapter)  {
> -	unsigned int i, num_vec, max_roce_eqs;
> +	unsigned int i, max_roce_eqs;
>  	struct device *dev = &adapter->pdev->dev;
> +	int num_vec;
>

Oops...thanks for catching this! This must go into net-next.

Acked-by: Sathya Perla <[email-masked]>