From: Ansuel Smith <ansuelsmth@gmail•com>
To: "Rafał Miłecki" <zajec5@gmail•com>
Cc: "Rob Herring" <robh+dt@kernel•org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro•org>,
"Pavel Machek" <pavel@ucw•cz>,
"David S . Miller" <davem@davemloft•net>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Hauke Mehrtens" <hauke@hauke-m•de>,
"Jacek Anaszewski" <jacek.anaszewski@gmail•com>,
devicetree@vger•kernel.org, netdev@vger•kernel.org,
linux-leds@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org,
bcm-kernel-feedback-list@broadcom•com, andrew@lunn•ch,
vivien.didelot@gmail•com, "Vladimir Oltean" <olteanv@gmail•com>,
"Jonathan Corbet" <corbet@lwn•net>,
"John Crispin" <john@phrozen•org>,
linux-doc@vger•kernel.org, "Rafał Miłecki" <rafal@milecki•pl>
Subject: Re: [PATCH RESEND 0/5] dt-bindings: support Ethernet devices as LED triggers
Date: Thu, 5 May 2022 16:30:30 +0200 [thread overview]
Message-ID: <6273df88.1c69fb81.1757e.5347@mx.google.com> (raw)
In-Reply-To: <b9ef7ce4-2a9d-9ecb-0aee-3f671c25d13f@gmail.com>
On Thu, May 05, 2022 at 04:21:33PM +0200, Rafał Miłecki wrote:
> On 5.05.2022 16:02, Ansuel Smith wrote:
> > On Thu, May 05, 2022 at 03:55:07PM +0200, Rafał Miłecki wrote:
> > > From: Rafał Miłecki <rafal@milecki•pl>
> > >
> > > Some LEDs are designed to represent a state of another device. That may
> > > be USB port, Ethernet interface, CPU, hard drive and more.
> > >
> > > We already have support for LEDs that are designed to indicate USB port
> > > (e.g. light on when USB device gets connected). There is DT binding for
> > > that and Linux implementation in USB trigger.
> > >
> > > This patchset adds support for describing LEDs that should react to
> > > Ethernet interface status. That is commonly used in routers. They often
> > > have LED to display state and activity of selected physical port. It's
> > > also common to have multiple LEDs, each reacting to a specific link
> > > speed.
> > >
> >
> > I notice this is specific to ethernet speed... I wonder if we should
> > expand this also to other thing like duplex state or even rx/tx.
>
> I didn't see any router with separated Rx/Tx LEDs, but it still sounds
> like a valid case.
>
Not a normal configuration but it's doable. For qca8k you can really set
the led to do whatever you want.
> We could add flags for that in proposed field like:
> trigger-sources = <&port (SPEED_1000 | LINK | TX)>;
>
> Or add separated field for non-speed flags like:
> trigger-sources = <&port SPEED_1000 (LINK | TX)>;
>
> Let's see what DT experts say about it.
--
Ansuel
prev parent reply other threads:[~2022-05-05 14:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 13:55 [PATCH RESEND 0/5] dt-bindings: support Ethernet devices as LED triggers Rafał Miłecki
2022-05-05 13:55 ` [PATCH RESEND 1/5] dt-bindings: net: add bitfield defines for Ethernet speeds Rafał Miłecki
2022-05-17 20:35 ` Rob Herring
2022-05-05 13:55 ` [PATCH RESEND 2/5] dt-bindings: net: allow Ethernet devices as LED triggers Rafał Miłecki
2022-05-17 20:37 ` Rob Herring
2022-05-05 13:55 ` [PATCH RESEND 3/5] dt-bindings: leds: add Ethernet triggered LEDs to example Rafał Miłecki
2022-05-05 13:55 ` [PATCH RESEND 4/5] ARM: dts: BCM5301X: Add triggers for Luxul XWR-1200 network LEDs Rafał Miłecki
2022-05-05 13:55 ` [PATCH RESEND PoC] leds: trigger: netdev: support DT "trigger-sources" property Rafał Miłecki
2022-05-05 14:02 ` [PATCH RESEND 0/5] dt-bindings: support Ethernet devices as LED triggers Ansuel Smith
2022-05-05 14:21 ` Rafał Miłecki
2022-05-05 14:30 ` Ansuel Smith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6273df88.1c69fb81.1757e.5347@mx.google.com \
--to=ansuelsmth@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hauke@hauke-m$(echo .)de \
--cc=jacek.anaszewski@gmail$(echo .)com \
--cc=john@phrozen$(echo .)org \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=pavel@ucw$(echo .)cz \
--cc=rafal@milecki$(echo .)pl \
--cc=robh+dt@kernel$(echo .)org \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=zajec5@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox