Subject: Re: [PATCH v2 bpf-next] net: netfilter: move bpf_ct_set_nat_info kfunc in nf_nat_bpf.c

From: John Fastabend <[email-masked]>
Date: Thu, 29 Sep 2022 19:35:34 -0700

Martin KaFai Lau wrote:
> On 9/29/22 3:38 PM, Lorenzo Bianconi wrote:
> > Remove circular dependency between nf_nat module and nf_conntrack one
> > moving bpf_ct_set_nat_info kfunc in nf_nat_bpf.c
> > 
> > Fixes: 0fabd2aa199f ("net: netfilter: add bpf_ct_set_nat_info kfunc helper")
> > Suggested-by: Kumar Kartikeya Dwivedi <[email-masked]>
> > Tested-by: Nathan Chancellor <[email-masked]>
> > Tested-by: Yauheni Kaliuta <[email-masked]>
> > Signed-off-by: Lorenzo Bianconi <[email-masked]>
> > ---
> > Changes since v1:
> > - move register_nf_nat_bpf declaration in nf_conntrack_bpf.h
> > ---
> >   include/net/netfilter/nf_conntrack_bpf.h | 19 ++++++
> >   net/netfilter/Makefile                   |  6 ++
> >   net/netfilter/nf_conntrack_bpf.c         | 50 ---------------
> >   net/netfilter/nf_nat_bpf.c               | 79 ++++++++++++++++++++++++
> >   net/netfilter/nf_nat_core.c              |  4 +-
> 
> lgtm.  It should have addressed Pablo's comment in v1.  Can the netfilter team 
> give an ack for the patch?
> 

Also lgtm

Acked-by: John Fastabend <[email-masked]>