From: Christian Marangi <ansuelsmth@gmail•com>
To: Andrew Lunn <andrew@lunn•ch>
Cc: "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Rob Herring <robh+dt@kernel•org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro•org>,
Conor Dooley <conor+dt@kernel•org>,
Heiner Kallweit <hkallweit1@gmail•com>,
Russell King <linux@armlinux•org.uk>,
netdev@vger•kernel.org, devicetree@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: [net-next PATCH 1/2] dt-bindings: Document QCA808x PHYs
Date: Mon, 11 Dec 2023 18:19:46 +0100 [thread overview]
Message-ID: <657744b5.050a0220.dfa0d.11a4@mx.google.com> (raw)
In-Reply-To: <74b7fc4f-88d2-41c0-8d98-6530f0fc2d70@lunn.ch>
On Mon, Dec 11, 2023 at 04:54:12PM +0100, Andrew Lunn wrote:
> > Mhhh with a generic property and LED core or phylib handling it... How
> > it would work applying that setting on PHY side?
>
> Add a .led_set_polarity callback to the PHY driver structure?
>
> Take a look at other LED drivers. Does anything similar already exist?
> It is unlikely that PHYs are the only sort of LED to have a polarity.
>
Interesting topic... With a quick grep on Documentation for polarity of
high, I can't find any use of it...
Also main problem is that the thing is controlled globally and not per
LED. (can be handled internally to the driver with some priv and check
magic)
Is it worth to impemement the additional API to control this? And I
guess a egenric binding should be added to ethernet-phy? Or should it be
added to LEDs?
--
Ansuel
next prev parent reply other threads:[~2023-12-11 17:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 1:48 [net-next PATCH 1/2] dt-bindings: Document QCA808x PHYs Christian Marangi
2023-12-09 1:48 ` [net-next PATCH 2/2] net: phy: at803x: add LED support for qca808x Christian Marangi
2023-12-09 12:38 ` kernel test robot
2023-12-09 12:44 ` Christian Marangi
2023-12-11 15:50 ` Andrew Lunn
2023-12-09 18:24 ` kernel test robot
2023-12-11 10:19 ` [net-next PATCH 1/2] dt-bindings: Document QCA808x PHYs Krzysztof Kozlowski
2023-12-11 12:18 ` Christian Marangi
2023-12-11 16:01 ` Krzysztof Kozlowski
2023-12-11 15:44 ` Andrew Lunn
2023-12-11 15:48 ` Christian Marangi
2023-12-11 15:54 ` Andrew Lunn
2023-12-11 17:19 ` Christian Marangi [this message]
2023-12-11 17:49 ` Andrew Lunn
2023-12-11 17:57 ` Christian Marangi
2023-12-11 15:49 ` Christian Marangi
2023-12-11 15:51 ` Andrew Lunn
2023-12-11 15:57 ` Christian Marangi
2023-12-13 18:46 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=657744b5.050a0220.dfa0d.11a4@mx.google.com \
--to=ansuelsmth@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox