Subject: Re: [net-next PATCH v3 1/4] dt-bindings: net: phy: Document new LEDs active-low property

From: Christian Marangi <[email-masked]>
Date: Fri, 15 Dec 2023 15:24:16 +0100

On Fri, Dec 15, 2023 at 04:48:35PM +0100, Krzysztof Kozlowski wrote:
> On 13/12/2023 12:13, Christian Marangi wrote:
> > Document new LEDs active-low property to define if the LED require to be
> > set low to be turned on.
> > 
> > active-low can be defined in the leds node for PHY that apply the LED
> > polarity globally for each attached LED or in the specific led node for
> > PHY that supports setting the LED polarity per LED.
> > 
> > Declaring both way is not supported and will result in the schema
> > getting rejected.
> > 
> > Signed-off-by: Christian Marangi <[email-masked]>
> > ---
> > Changes v3:
> > - Out of RFC
> > Changes v2:
> > - Add this patch
> > 
> >  .../devicetree/bindings/net/ethernet-phy.yaml | 20 +++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> > index 8fb2a6ee7e5b..9cb3981fed2a 100644
> > --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> > +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> > @@ -213,6 +213,11 @@ properties:
> >        '#size-cells':
> >          const: 0
> >  
> > +      'active-low':
> 
> Drop quotes, no need for them.
> 
> As pointed out in other patchset, bool might not be enough.
> https://lore.kernel.org/all/[email-masked]/
> Anyway, both cases probably needs to be considered here.
>

Hi, thanks for pointing me to that series. Leaved some message there,
would love if you can check some ideas on how to handle the LED
polarity thing DT wise.

-- 
	Ansuel