Subject: Re: [net-next PATCH v5 3/4] net: dsa: Add Airoha AN8855 5-Port Gigabit DSA Switch driver

From: Christian Marangi <[email-masked]>
Date: Fri, 15 Nov 2024 22:59:18 +0100

On Thu, Nov 14, 2024 at 07:22:02PM -0800, Jakub Kicinski wrote:
> On Tue, 12 Nov 2024 21:47:26 +0100 Christian Marangi wrote:
> > +	MIB_DESC(1, 0x00, "TxDrop"),
> > +	MIB_DESC(1, 0x04, "TxCrcErr"),
> 
> What is a CRC Tx error :o 
> Just out of curiosity, not saying its worng.
>

>From Documentation, FCS error frame due to TX FIFO underrun.

> > +	MIB_DESC(1, 0x08, "TxUnicast"),
> > +	MIB_DESC(1, 0x0c, "TxMulticast"),
> > +	MIB_DESC(1, 0x10, "TxBroadcast"),
> > +	MIB_DESC(1, 0x14, "TxCollision"),
> 
> Why can't these be rtnl stats, please keep in mind that we ask that
> people don't duplicate in ethtool -S what can be exposed via standard
> stats
> 

Ok I will search for this but it does sounds like something new and not
used by other DSA driver, any hint on where to look for examples?

> > +	MIB_DESC(1, 0x18, "TxSingleCollision"),
> > +	MIB_DESC(1, 0x1c, "TxMultipleCollision"),
> > +	MIB_DESC(1, 0x20, "TxDeferred"),
> > +	MIB_DESC(1, 0x24, "TxLateCollision"),
> > +	MIB_DESC(1, 0x28, "TxExcessiveCollistion"),
> > +	MIB_DESC(1, 0x2c, "TxPause"),
> > +	MIB_DESC(1, 0x30, "TxPktSz64"),
> > +	MIB_DESC(1, 0x34, "TxPktSz65To127"),
> > +	MIB_DESC(1, 0x38, "TxPktSz128To255"),
> > +	MIB_DESC(1, 0x3c, "TxPktSz256To511"),
> > +	MIB_DESC(1, 0x40, "TxPktSz512To1023"),
> > +	MIB_DESC(1, 0x44, "TxPktSz1024To1518"),
> > +	MIB_DESC(1, 0x48, "TxPktSz1519ToMax"),
> 
> we have standard stats for rmon, too
> 
> > +	MIB_DESC(2, 0x4c, "TxBytes"),
> > +	MIB_DESC(1, 0x54, "TxOversizeDrop"),
> > +	MIB_DESC(2, 0x58, "TxBadPktBytes"),
> > +	MIB_DESC(1, 0x80, "RxDrop"),
> > +	MIB_DESC(1, 0x84, "RxFiltering"),
> > +	MIB_DESC(1, 0x88, "RxUnicast"),
> > +	MIB_DESC(1, 0x8c, "RxMulticast"),
> > +	MIB_DESC(1, 0x90, "RxBroadcast"),
> > +	MIB_DESC(1, 0x94, "RxAlignErr"),
> > +	MIB_DESC(1, 0x98, "RxCrcErr"),
> > +	MIB_DESC(1, 0x9c, "RxUnderSizeErr"),
> > +	MIB_DESC(1, 0xa0, "RxFragErr"),
> > +	MIB_DESC(1, 0xa4, "RxOverSzErr"),
> > +	MIB_DESC(1, 0xa8, "RxJabberErr"),
> > +	MIB_DESC(1, 0xac, "RxPause"),
> > +	MIB_DESC(1, 0xb0, "RxPktSz64"),
> > +	MIB_DESC(1, 0xb4, "RxPktSz65To127"),
> > +	MIB_DESC(1, 0xb8, "RxPktSz128To255"),
> > +	MIB_DESC(1, 0xbc, "RxPktSz256To511"),
> > +	MIB_DESC(1, 0xc0, "RxPktSz512To1023"),
> > +	MIB_DESC(1, 0xc4, "RxPktSz1024To1518"),
> > +	MIB_DESC(1, 0xc8, "RxPktSz1519ToMax"),
> > +	MIB_DESC(2, 0xcc, "RxBytes"),
> > +	MIB_DESC(1, 0xd4, "RxCtrlDrop"),
> > +	MIB_DESC(1, 0xd8, "RxIngressDrop"),
> > +	MIB_DESC(1, 0xdc, "RxArlDrop"),
> > +	MIB_DESC(1, 0xe0, "FlowControlDrop"),
> > +	MIB_DESC(1, 0xe4, "WredDrop"),
> > +	MIB_DESC(1, 0xe8, "MirrorDrop"),
> > +	MIB_DESC(2, 0xec, "RxBadPktBytes"),
> > +	MIB_DESC(1, 0xf4, "RxsFlowSamplingPktDrop"),
> > +	MIB_DESC(1, 0xf8, "RxsFlowTotalPktDrop"),
> > +	MIB_DESC(1, 0xfc, "PortControlDrop"),
> -- 
> pw-bot: cr

-- 
	Ansuel