Subject: Re: [PATCH net-next 7/8] vhost_net: try batch dequing from skb array

From: Pankaj Gupta <[email-masked]>
Date: Wed, 29 Mar 2017 06:46:27 -0400 (EDT)

Hi Jason,

> 
> On 2017年03月23日 13:34, Jason Wang wrote:
> >
> >
> >>
> >>> +{
> >>> +    if (rvq->rh != rvq->rt)
> >>> +        goto out;
> >>> +
> >>> +    rvq->rh = rvq->rt = 0;
> >>> +    rvq->rt = skb_array_consume_batched_bh(rvq->rx_array, rvq->rxq,
> >>> +                        VHOST_RX_BATCH);
> >> A comment explaining why is is -bh would be helpful.
> >
> > Ok.
> >
> > Thanks
> 
> Rethink about this. It looks like -bh is not needed in this case since
> no consumer run in bh.

In that case do we need other variants of "ptr_ring_consume_batched_*()" functions.
Are we planning to use them in future? 

> Thanks
_______________________________________________
Virtualization mailing list
[email-masked]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization