From: Hau <hau@realtek•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: Horatiu Vultur <horatiu.vultur@microchip•com>,
"hkallweit1@gmail•com" <hkallweit1@gmail•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
nic_swsd <nic_swsd@realtek•com>
Subject: RE: [PATCH net] r8169: fix rtl8168h rx crc error
Date: Thu, 23 Mar 2023 13:57:48 +0000 [thread overview]
Message-ID: <681a087e08f646ceb22f7febcae75332@realtek.com> (raw)
In-Reply-To: <20230322125934.102876c1@kernel.org>
> On Wed, 22 Mar 2023 12:13:12 +0000 Hau wrote:
> > > Don't forget to add the fixes tag.
> > > Another comment that I usually get is to replace hardcoded values
> > > with defines, but on the other side I can see that this file already
> > > has plently of hardcoded values.
> >
> > It is not a fix for a specific commit. PHY 10m pll off is an power
> > saving feature which is enabled by H/W default. This issue can be
> > fixed by disable PHY 10m pll off.
>
> How far back can the issue be reproduced? Is it only possible with certain
> device types? Then the Fixes tag should point at the commit which added
> support for the devices. Was it always present since 2.6 kernels? Put the first
> commit in the git history as Fixes.
>
RTL8168H is the only chip we know that has this issue. This issue is related to the H/W default setting.
So I will add a Fixes tag to the commit which added support for this chip and submit the patch again.
------Please consider the environment before printing this e-mail.
prev parent reply other threads:[~2023-03-23 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 6:45 [PATCH net] r8169: fix rtl8168h rx crc error ChunHao Lin
2023-03-22 8:21 ` Horatiu Vultur
2023-03-22 12:13 ` Hau
2023-03-22 19:59 ` Jakub Kicinski
2023-03-23 13:57 ` Hau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=681a087e08f646ceb22f7febcae75332@realtek.com \
--to=hau@realtek$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=horatiu.vultur@microchip$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nic_swsd@realtek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox