From: "Nambiar, Amritha" <amritha.nambiar@intel•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: <netdev@vger•kernel.org>, <davem@davemloft•net>,
<sridhar.samudrala@intel•com>
Subject: Re: [net-next PATCH v1 3/9] netdev-genl: spec: Extend netdev netlink spec in YAML for NAPI
Date: Mon, 31 Jul 2023 16:12:23 -0700 [thread overview]
Message-ID: <6cb18abe-89aa-a8a8-a7e1-8856acaaef64@intel.com> (raw)
In-Reply-To: <20230731123651.45b33c89@kernel.org>
On 7/31/2023 12:36 PM, Jakub Kicinski wrote:
> On Fri, 28 Jul 2023 17:47:07 -0700 Amritha Nambiar wrote:
>> + -
>> + name: napi
>> + attributes:
>> + -
>> + name: ifindex
>> + doc: netdev ifindex
>> + type: u32
>> + checks:
>> + min: 1
>> + -
>> + name: napi-info
>> + doc: napi information such as napi-id, napi queues etc.
>> + type: nest
>> + multi-attr: true
>> + nested-attributes: napi-info-entry
>
> Every NAPI instance should be dumped as a separate object. We can
> implemented filtered dump to get NAPIs of a single netdev.
>
Today, the 'do napi-get <ifindex>' will show all the NAPIs for a single
netdev:
Example: --do napi-get --json='{"ifindex": 6}'
and the 'dump napi-get' will dump all the NAPIs for all the netdevs.
Example: netdev.yaml --dump napi-get
Are you suggesting that we also dump each NAPI instance individually,
'do napi-get <ifindex> <NAPI_ID>'
Example:
netdev.yaml --do napi-get --json='{"ifindex": 6, "napi-id": 390}'
[{'ifindex': 6},
{'napi-info': [{'irq': 296,
'napi-id': 390,
'pid': 3475,
'rx-queues': [5],
'tx-queues': [5]}]}]
next prev parent reply other threads:[~2023-07-31 23:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-29 0:46 [net-next PATCH v1 0/9] Introduce NAPI queues support Amritha Nambiar
2023-07-29 0:46 ` [net-next PATCH v1 1/9] net: Introduce new fields for napi and queue associations Amritha Nambiar
2023-07-29 9:55 ` kernel test robot
2023-07-30 17:10 ` Simon Horman
2023-07-31 22:57 ` Nambiar, Amritha
2023-07-29 0:47 ` [net-next PATCH v1 2/9] ice: Add support in the driver for associating napi with queue[s] Amritha Nambiar
2023-07-29 0:47 ` [net-next PATCH v1 3/9] netdev-genl: spec: Extend netdev netlink spec in YAML for NAPI Amritha Nambiar
2023-07-31 19:36 ` Jakub Kicinski
2023-07-31 23:12 ` Nambiar, Amritha [this message]
2023-08-01 0:13 ` Jakub Kicinski
2023-08-01 0:24 ` Nambiar, Amritha
2023-08-01 0:35 ` Jakub Kicinski
2023-08-09 0:17 ` Nambiar, Amritha
2023-08-09 2:45 ` Jakub Kicinski
2023-07-29 0:47 ` [net-next PATCH v1 4/9] net: Move kernel helpers for queue index outside sysfs Amritha Nambiar
2023-07-29 0:47 ` [net-next PATCH v1 5/9] netdev-genl: Add netlink framework functions for napi Amritha Nambiar
2023-07-30 17:15 ` Simon Horman
2023-07-31 23:00 ` Nambiar, Amritha
2023-07-31 19:37 ` Jakub Kicinski
2023-07-31 23:01 ` Nambiar, Amritha
2023-07-29 0:47 ` [net-next PATCH v1 6/9] netdev-genl: spec: Add irq in netdev netlink YAML spec Amritha Nambiar
2023-07-29 0:47 ` [net-next PATCH v1 7/9] net: Add NAPI IRQ support Amritha Nambiar
2023-07-29 4:05 ` Stephen Hemminger
2023-07-31 23:22 ` Nambiar, Amritha
2023-07-29 0:47 ` [net-next PATCH v1 8/9] netdev-genl: spec: Add PID in netdev netlink YAML spec Amritha Nambiar
2023-07-29 0:47 ` [net-next PATCH v1 9/9] netdev-genl: Add PID for the NAPI thread Amritha Nambiar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cb18abe-89aa-a8a8-a7e1-8856acaaef64@intel.com \
--to=amritha.nambiar@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sridhar.samudrala@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox