Subject: RE: [PATCH v1 net-next 6/6] net: ena: Add a field for no interrupt moderation update action

From: "Arinzon, David" <[email-masked]>
Date: Wed, 8 May 2024 05:55:50 +0000

> On Mon, 6 May 2024 07:04:53 +0000 [email-masked] wrote:
> > +     for (i = 0; i < adapter->num_io_queues; i++) {
> > +             adapter->rx_ring[i].interrupt_interval_changed =
> 
> Shouldn't this be |= ?
> 

Hi Jakub,

Thank you for reviewing the patch.

This is a true/false indicator, it doesn't require history/previous value to be considered.
Therefore, not sure I see the how |= can help us in the logic here.
The flag is set here to true if during the interrupt moderation update, which is, in this flow,
triggered by an ethtool operation, the moderation value has changed from the currently
configurated one.

> > +                     adapter->rx_ring[i].interrupt_interval != val;
> > +             adapter->rx_ring[i].interrupt_interval = val;
> > +     }