From: David Howells <dhowells@redhat•com>
To: Xin Long <lucien.xin@gmail•com>
Cc: dhowells@redhat•com, network dev <netdev@vger•kernel.org>,
davem@davemloft•net, Jakub Kicinski <kuba@kernel•org>,
pabeni@redhat•com, Willem de Bruijn <willemb@google•com>,
Martin Varghese <martin.varghese@nokia•com>,
Alexander Duyck <alexander.duyck@gmail•com>
Subject: Re: [PATCHv5 net-next 2/2] rxrpc: call udp_tunnel_encap_enable in rxrpc_open_socket
Date: Wed, 03 Feb 2021 09:50:42 +0000 [thread overview]
Message-ID: <707366.1612345842@warthog.procyon.org.uk> (raw)
In-Reply-To: <2da45aee43c74c05a586a7d3c7b1f9fc48bb72f2.1612342376.git.lucien.xin@gmail.com>
Xin Long <lucien.xin@gmail•com> wrote:
> When doing encap_enable/increasing encap_needed_key, up->encap_enabled
> is not set in rxrpc_open_socket(), and it will cause encap_needed_key
> not being decreased in udpv6_destroy_sock().
>
> This patch is to improve it by just calling udp_tunnel_encap_enable()
> where it increases both UDP and UDPv6 encap_needed_key and sets
> up->encap_enabled.
>
> v4->v5:
> - add the missing '#include <net/udp_tunnel.h>', as David Howells
> noticed.
>
> Acked-and-tested-by: David Howells <dhowells@redhat•com>
> Signed-off-by: Xin Long <lucien.xin@gmail•com>
Looks good.
David
next prev parent reply other threads:[~2021-02-03 9:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 8:54 [PATCHv5 net-next 0/2] net: enable udp v6 sockets receiving v4 packets with UDP Xin Long
2021-02-03 8:54 ` [PATCHv5 net-next 1/2] udp: call udp_encap_enable for v6 sockets when enabling encap Xin Long
2022-03-29 13:24 ` Antonio Quartulli
2022-03-29 13:30 ` Greg Kroah-Hartman
2022-03-31 13:06 ` Antonio Quartulli
2022-04-02 11:28 ` Greg Kroah-Hartman
2021-02-03 8:54 ` [PATCHv5 net-next 2/2] rxrpc: call udp_tunnel_encap_enable in rxrpc_open_socket Xin Long
2021-02-03 9:50 ` David Howells [this message]
2021-02-05 3:00 ` [PATCHv5 net-next 0/2] net: enable udp v6 sockets receiving v4 packets with UDP patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=707366.1612345842@warthog.procyon.org.uk \
--to=dhowells@redhat$(echo .)com \
--cc=alexander.duyck@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=lucien.xin@gmail$(echo .)com \
--cc=martin.varghese@nokia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox