Subject: Re: [PATCH 0/8] b44: add support for external PHY

From: Florian Fainelli <[email-masked]>
Date: Sun, 15 Dec 2013 21:26:51 +0000

Hello Hauke,

Le dimanche 15 décembre 2013, 19:41:57 Hauke Mehrtens a écrit :
> This adds support for an external phy connected to the mac controlled
> by b44. This is used on home routers of the BCM47xx line where this MAC
> core was used and is contended to an external switch core through MII.
> These patches are in OpenWrt for some time and are tested by different
> users with different devices.

Besides my comment on patch 8, this series looks fine to me, thanks!

Reviewed-by: Florian Fainelli <[email-masked]>

> 
> Hauke Mehrtens (8):
>   b44: cheek register instead of PHY address to detect external PHY
>   b44: rename B44_PHY_ADDR_NO_PHY to B44_PHY_ADDR_NO_LOCAL_PHY
>   b44: abort when no PHY is available at all
>   b44: rename b44_mii_{read,write} to b44_mdio_{read,write}_mii
>   b44: add phylib support
>   b44: activate PHY when MAC is off
>   b44: do not set PHY address to 30 for every ext PHY
>   b44: add dummy PHY device if we do not find any
> 
>  drivers/net/ethernet/broadcom/Kconfig |    1 +
>  drivers/net/ethernet/broadcom/b44.c   |  254
> ++++++++++++++++++++++++++++++--- drivers/net/ethernet/broadcom/b44.h   |  
> 15 +-
>  3 files changed, 244 insertions(+), 26 deletions(-)

-- 
Florian