From: Lance Richardson <lrichard@redhat•com>
To: Shmulik Ladkani <shmulik.ladkani@gmail•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net] ip6_gre: fix flowi6_proto value in ip6gre_xmit_other()
Date: Fri, 23 Sep 2016 15:52:24 -0400 (EDT) [thread overview]
Message-ID: <745948754.3473250.1474660344493.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20160923220036.55d469b0@halley>
> From: "Shmulik Ladkani" <shmulik.ladkani@gmail•com>
> To: "Lance Richardson" <lrichard@redhat•com>
> Cc: netdev@vger•kernel.org
> Sent: Friday, September 23, 2016 3:00:36 PM
> Subject: Re: [PATCH net] ip6_gre: fix flowi6_proto value in ip6gre_xmit_other()
>
> On Fri, 23 Sep 2016 12:54:59 -0400 Lance Richardson <lrichard@redhat•com>
> wrote:
> > Similar to commit 3be07244b733 ("ip6_gre: fix flowi6_proto value in
> > xmit path"), set flowi6_proto to IPPROTO_GRE for output route lookup.
>
> Suggesting to add:
>
> Up until now, 'ip6gre_xmit_other' has set flowi6_proto to a bogus value.
> This affects output route lookup upon xmit of non ipv4/ipv6 packets on a
> ip6gretap device, in cases where routing depends on flowi6_proto.
>
Added in v2, taking some editorial license (please let me know if I mangled it
too badly).
Thanks,
Lance
> > Since the correct proto is already set in the tunnel flowi6 template via
> > commit 252f3f5a1189 ("ip6_gre: Set flowi6_proto as IPPROTO_GRE in xmit
> > path."), simply delete the line setting the incorrect flowi6_proto value.
> >
> > Suggested-by: Jiri Benc <jbenc@redhat•com>
> > Fixes: commit c12b395a4664 ("gre: Support GRE over IPv6")
> > Signed-off-by: Lance Richardson <lrichard@redhat•com>
>
> Reviewed-by: Shmulik Ladkani <shmulik.ladkani@gmail•com>
>
next prev parent reply other threads:[~2016-09-23 19:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 16:54 [PATCH net] ip6_gre: fix flowi6_proto value in ip6gre_xmit_other() Lance Richardson
2016-09-23 19:00 ` Shmulik Ladkani
2016-09-23 19:52 ` Lance Richardson [this message]
2016-09-23 19:57 ` Shmulik Ladkani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=745948754.3473250.1474660344493.JavaMail.zimbra@redhat.com \
--to=lrichard@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shmulik.ladkani@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox