From: Sander Eikelenboom <linux@eikelenboom•it>
To: Ian Campbell <Ian.Campbell@citrix•com>
Cc: Eric Dumazet <eric.dumazet@gmail•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Eric Dumazet <edumazet@google•com>,
xen-devel <xen-devel@lists•xen.org>,
"Konrad Rzeszutek Wilk" <konrad@kernel•org>
Subject: Re: [Xen-devel] compound skb frag pages appearing in start_xmit
Date: Wed, 10 Oct 2012 16:49:49 +0200 [thread overview]
Message-ID: <748966751.20121010164949@eikelenboom.it> (raw)
In-Reply-To: <1349874598.10070.39.camel@zakaz.uk.xensource.com>
Wednesday, October 10, 2012, 3:09:58 PM, you wrote:
> On Wed, 2012-10-10 at 11:13 +0100, Ian Campbell wrote:
>> I haven't tackled netfront yet.
> I seem to be totally unable to reproduce the equivalent issue on the
> netfront xmit side, even though it seems like the loop in
> xennet_make_frags ought to be obviously susceptible to it.
> Konrad, Sander, are either of you able to repro, e.g. with:
Hmrrrmm i don't see any traces, only strange behaviour ..
- i can connect to guests by ssh, but it's sluggish, and sometimes stops working
- The guest seem to keep trying to connect to netback:
[ 658.276719] xen_bridge: port 2(vif40.0) entered forwarding state
[ 658.282258] xen_bridge: port 2(vif40.0) entered forwarding state
[ 663.945964] xen_bridge: port 7(vif39.0) entered forwarding state
[ 669.674277] xen_bridge: port 2(vif40.0) entered disabled state
[ 669.680290] device vif40.0 left promiscuous mode
[ 669.685464] xen_bridge: port 2(vif40.0) entered disabled state
[ 672.857222] device vif41.0 entered promiscuous mode
[ 673.166254] xen-blkback:ring-ref 8, event-channel 9, protocol 1 (x86_64-abi)
[ 673.176368] xen_bridge: port 2(vif41.0) entered forwarding state
[ 673.182042] xen_bridge: port 2(vif41.0) entered forwarding state
[ 674.439725] xen_bridge: port 7(vif39.0) entered disabled state
[ 674.445708] device vif39.0 left promiscuous mode
[ 674.450955] xen_bridge: port 7(vif39.0) entered disabled state
[ 677.726040] device vif42.0 entered promiscuous mode
[ 678.053381] xen-blkback:ring-ref 8, event-channel 9, protocol 1 (x86_64-abi)
[ 678.062804] xen_bridge: port 7(vif42.0) entered forwarding state
[ 678.068433] xen_bridge: port 7(vif42.0) entered forwarding state
[ 688.224736] xen_bridge: port 2(vif41.0) entered forwarding state
[ 693.080557] xen_bridge: port 7(vif42.0) entered forwarding state
[ 700.786276] xen_bridge: port 7(vif42.0) entered disabled state
[ 700.792484] device vif42.0 left promiscuous mode
[ 700.802409] xen_bridge: port 7(vif42.0) entered disabled state
[ 704.133606] device vif43.0 entered promiscuous mode
[ 704.460160] xen-blkback:ring-ref 8, event-channel 9, protocol 1 (x86_64-abi)
[ 704.469800] xen_bridge: port 7(vif43.0) entered forwarding state
[ 704.475303] xen_bridge: port 7(vif43.0) entered forwarding state
[ 719.493788] xen_bridge: port 7(vif43.0) entered forwarding state
[ 726.302456] xen_bridge: port 7(vif43.0) entered disabled state
[ 726.308898] device vif43.0 left promiscuous mode
[ 726.314029] xen_bridge: port 7(vif43.0) entered disabled state
All the guests are already up, but this keeps on going and going and going ....
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index b06ef81..8a3f770 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -462,6 +462,8 @@ static void xennet_make_frags(struct sk_buff *skb, struct net_device *dev,
> ref = gnttab_claim_grant_reference(&np->gref_tx_head);
> BUG_ON((signed short)ref < 0);
>
> + BUG_ON(PageCompound(skb_frag_page(frag)));
> +
> mfn = pfn_to_mfn(page_to_pfn(skb_frag_page(frag)));
> gnttab_grant_foreign_access_ref(ref, np->xbdev->otherend_id,
> mfn, GNTMAP_readonly);
> My repro for netback was just to netcat a wodge of data from dom0->domU
> but going the other way doesn't seem to trigger.
next prev parent reply other threads:[~2012-10-10 14:49 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 13:47 compound skb frag pages appearing in start_xmit Ian Campbell
2012-10-09 13:54 ` Eric Dumazet
2012-10-09 14:01 ` Eric Dumazet
2012-10-09 14:23 ` Ian Campbell
2012-10-09 14:33 ` Eric Dumazet
2012-10-09 14:54 ` Ian Campbell
2012-10-09 14:17 ` Ian Campbell
2012-10-09 14:27 ` Eric Dumazet
2012-10-09 14:40 ` Ian Campbell
2012-10-09 14:51 ` Eric Dumazet
2012-10-10 10:13 ` [Xen-devel] " Ian Campbell
2012-10-10 12:24 ` Sander Eikelenboom
2012-10-10 12:29 ` [Xen-devel] " Ian Campbell
2012-10-10 13:31 ` Sander Eikelenboom
2012-10-10 13:09 ` Ian Campbell
2012-10-10 14:49 ` Sander Eikelenboom [this message]
2012-10-11 8:02 ` Ian Campbell
2012-10-11 10:00 ` Sander Eikelenboom
2012-10-11 10:05 ` Eric Dumazet
2012-10-11 10:14 ` Ian Campbell
2012-10-11 10:20 ` Sander Eikelenboom
2012-11-15 2:31 ` ANNIE LI
2012-11-19 15:43 ` Sander Eikelenboom
2012-11-20 8:30 ` [Xen-devel] " Stefan Bader
2012-11-20 9:21 ` Ian Campbell
2012-11-20 11:36 ` [Xen-devel] " Ian Campbell
2012-11-21 2:42 ` ANNIE LI
2012-11-20 11:40 ` [PATCH] xen/netfront: handle compound page fragments on transmit Ian Campbell
2012-11-20 12:28 ` [Xen-devel] " Jan Beulich
2012-11-20 13:35 ` Ian Campbell
2012-11-20 13:51 ` Jan Beulich
2012-11-20 14:14 ` Ian Campbell
2012-11-20 14:32 ` Jan Beulich
2012-11-20 15:06 ` Ian Campbell
2012-11-20 15:28 ` Eric Dumazet
2012-11-20 15:54 ` Ian Campbell
2012-11-20 15:44 ` Jan Beulich
2012-11-20 16:14 ` Eric Dumazet
2012-11-20 13:30 ` Stefan Bader
2012-11-20 13:45 ` Sander Eikelenboom
2012-11-20 14:45 ` Eric Dumazet
2012-11-20 15:05 ` Ian Campbell
2012-11-21 2:52 ` ANNIE LI
2012-11-21 11:09 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=748966751.20121010164949@eikelenboom.it \
--to=linux@eikelenboom$(echo .)it \
--cc=Ian.Campbell@citrix$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=konrad@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xen-devel@lists$(echo .)xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox